Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI improvements on sidebar and multinode buttons #84

Merged
merged 1 commit into from
Aug 15, 2019
Merged

UI improvements on sidebar and multinode buttons #84

merged 1 commit into from
Aug 15, 2019

Conversation

my8100
Copy link
Owner

@my8100 my8100 commented Aug 15, 2019

No description provided.

@pep8speaks
Copy link

Hello @my8100! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 100:121: E501 line too long (124 > 120 characters)

@coveralls
Copy link

coveralls commented Aug 15, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 267

  • 15 of 16 (93.75%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased ( 0.02%) to 87.966%
Changes Missing Coverage Covered Lines Changed/Added Lines %
scrapydweb/run.py 0 1 0.0%
Totals Coverage Status
Change from base Build 247: 0.02%
Covered Lines: 3516
Relevant Lines: 3997
💛 - Coveralls

@codecov
Copy link

codecov bot commented Aug 15, 2019 •
edited
Loading

Codecov Report

Merging #84 into master will increase coverage by 0.06%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #84       /-   ##
==========================================
  Coverage   89.47%   89.54%    0.06%     
==========================================
  Files          34       34              
  Lines        3990     3997        7     
==========================================
  Hits         3570     3579        9     
  Misses        420      418       -2
Impacted Files Coverage Δ
scrapydweb/default_settings.py 100% <ø> (ø) ⬆️
scrapydweb/run.py 0% <0%> (ø) ⬆️
scrapydweb/views/overview/tasks.py 98.12% <100%> ( 0.01%) ⬆️
scrapydweb/utils/check_app_config.py 84.42% <100%> (ø) ⬆️
scrapydweb/utils/send_email.py 91.66% <100%> ( 0.11%) ⬆️
scrapydweb/views/baseview.py 89.39% <100%> (ø) ⬆️
scrapydweb/views/dashboard/jobs.py 92.4% <100%> ( 0.04%) ⬆️
scrapydweb/views/utilities/send_text.py 100% <100%> (ø) ⬆️
scrapydweb/views/files/log.py 95.54% <0%> ( 0.52%) ⬆️

@my8100 my8100 merged commit 6033e7e into master Aug 15, 2019
@my8100 my8100 deleted the sidebar_multinode_buttons branch August 15, 2019 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@my8100 @pep8speaks @coveralls