Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cookbook for v1 #143

Open
wants to merge 21 commits into
base: feat/next
Choose a base branch
from
Open

Cookbook for v1 #143

wants to merge 21 commits into from

Conversation

popenta
Copy link
Collaborator

@popenta popenta commented Nov 8, 2024 •
edited by andreibancioiu
Loading

@popenta popenta self-assigned this Nov 8, 2024
@popenta popenta marked this pull request as draft November 8, 2024 14:04
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024 •
edited
Loading

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  multiversx_sdk
  __init__.py
  multiversx_sdk/account_management
  account_transactions_factory.py
  multiversx_sdk/entrypoints
  entrypoints.py 106
  multiversx_sdk/network_providers
  api_network_provider.py 120
  proxy_network_provider.py 101, 152
  multiversx_sdk/testutils
  mock_network_provider.py 165
  multiversx_sdk/wallet
  __init__.py
Project Total  

This report was generated by python-coverage-comment-action

@andreibancioiu andreibancioiu self-requested a review November 8, 2024 14:08
andreibancioiu
andreibancioiu previously approved these changes Nov 8, 2024
View reviewed changes
@andreibancioiu andreibancioiu mentioned this pull request Dec 10, 2024
Closed
@popenta popenta marked this pull request as ready for review December 12, 2024 13:31
andreibancioiu
andreibancioiu reviewed Dec 18, 2024
View reviewed changes
Copy link
Contributor

@andreibancioiu andreibancioiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job 📖 🚀

A few comments on Slack.

@andreibancioiu andreibancioiu changed the title Update cookbook Cookbook vor v1 Dec 18, 2024
@andreibancioiu andreibancioiu changed the title Cookbook vor v1 Cookbook for v1 Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreibancioiu andreibancioiu andreibancioiu left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@popenta popenta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@popenta @andreibancioiu