Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected behavior when PUTing a contact with legacy waitlists #734

Closed
grahamalama opened this issue Jul 5, 2023 · 1 comment · Fixed by #722
Closed

Unexpected behavior when PUTing a contact with legacy waitlists #734

grahamalama opened this issue Jul 5, 2023 · 1 comment · Fixed by #722
Assignees
@leplatrem
Labels
bug Something isn't working

Comments

@grahamalama
Copy link
Contributor

  1. POST contact with a legacy waitlist field (VPN):
...
 'relay_waitlist': None,
 'vpn_waitlist': {'geo': 'us', 'platform': None},
 'waitlists': []
}

success ✅

  1. GET that object back, looks like this:
 'relay_waitlist': {'geo': None},
...
 'vpn_waitlist': {'geo': 'us', 'platform': None},
 'waitlists': [{'fields': {'geo': 'us', 'platform': None},
                'name': 'vpn',
                'source': None}]
}
  1. PUT the contact, signing up for another waitlist through a legacy field (Relay):
 'relay_waitlist': {'geo': 'us'},
 'vpn_waitlist': {'geo': 'us', 'platform': None},
 'waitlists': [{'fields': {'geo': 'us', 'platform': None},
                'name': 'vpn',
                'source': None,
                'subscribed': True}]
}

Expected: User is signed up for the relay and vpn waitlists
Actual: User is only signed up for the VPN waitlist

I'm pretty sure that's because of this.
@grahamalama grahamalama added the bug Something isn't working label Jul 5, 2023
@leplatrem leplatrem self-assigned this Jul 6, 2023
@leplatrem
Copy link
Contributor

Since Basket does not set those fields anymore, this is less urgent than #733

@leplatrem leplatrem mentioned this issue Jul 12, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leplatrem leplatrem

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@leplatrem @grahamalama