Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STOMP planning algorithm in HUMBLE #2742

Closed
Jakubivan opened this issue Mar 14, 2024 · 8 comments
Closed

STOMP planning algorithm in HUMBLE #2742

Jakubivan opened this issue Mar 14, 2024 · 8 comments
Labels
enhancement New feature or request stale Inactive issues and PRs are marked as stale and may be closed automatically.

Comments

@Jakubivan
Copy link

Reopened
#2550

I see that STOMP planner is added in Iron, but not in humble.

If I wanted to use in humble, would it be as easy as coping the code from moveit_planners into my local source (humble)? are there any other nuances that I should be aware of?

@Jakubivan Jakubivan added the enhancement New feature or request label Mar 14, 2024
@angeelalg
Copy link

I am in a similar situation, I would like to be able to use STOMP in Foxy. By modifying moveit_planners could it work directly or does it require modifications in other parts of the repository?

@Jakubivan
Copy link
Author

I am in a similar situation, I would like to be able to use STOMP in Foxy. By modifying moveit_planners could it work directly or does it require modifications in other parts of the repository?

Modifying moveit_planners worked for me. However, I was not able to plan under orientation constraints since it reached one of the stop conditions (mainly num_iterations). In the previous generation of ROS (ROS1 Noetic), I worked with a custom noise generator which was able to fulfill my requirements for planning under constraints. Sadly, this is not possible (or I do not know how) in ROS2 using rebuilt STOMP.

I have cherry-picked all the commits from the main regarding MoveIt2 - https://github.com/Jakubivan/moveit2/tree/ivan/humble-w-stomp to my Humble branch.

In moveit config package, add file stomp_planning.yaml with the keys:

planning_plugin: stomp_moveit/StompPlanner
request_adapters: >-
  default_planner_request_adapters/AddTimeOptimalParameterization
  default_planner_request_adapters/ResolveConstraintFrames
  default_planner_request_adapters/FixWorkspaceBounds
  default_planner_request_adapters/FixStartStateBounds
  default_planner_request_adapters/FixStartStateCollision
  default_planner_request_adapters/FixStartStatePathConstraints


num_timesteps: 40
num_iterations: 10000
num_iterations_after_valid: 0
num_rollouts: 15
max_rollouts: 25
exponentiated_cost_sensitivity: 0.4
control_cost_weight: 0.1
delta_t: 0.1
path_marker_topic: 'path_marker'

Copy link

This issue is being labeled as stale because it has been open 45 days with no activity. It will be automatically closed after another 45 days without follow-ups.

@github-actions github-actions bot added the stale Inactive issues and PRs are marked as stale and may be closed automatically. label May 31, 2024
@antonio1matos
Copy link

Hi @Jakubivan
I'm also using MoveIt Humble and i also wanted to use the planner stomp in this moveit.
So you basically just had to copy the folder stomp from: https://github.com/moveit/moveit2/tree/main/moveit_planners/stomp
and paste it in the folder: moveit_planners from your moveit2 workspace (which in my case is the path: ws_moveit2/src/moveit2/moveit_planners)?
After that you just did colcon build of the workspace and the moveit is already configured with this planner? And if so didn´t you had to change anything else from that workspace? Such as other files?
Regards
António Matos

@github-actions github-actions bot removed the stale Inactive issues and PRs are marked as stale and may be closed automatically. label Jun 5, 2024
@Jakubivan
Copy link
Author

Hi @Jakubivan I'm also using MoveIt Humble and i also wanted to use the planner stomp in this moveit. So you basically just had to copy the folder stomp from: https://github.com/moveit/moveit2/tree/main/moveit_planners/stomp and paste it in the folder: moveit_planners from your moveit2 workspace (which in my case is the path: ws_moveit2/src/moveit2/moveit_planners)? After that you just did colcon build of the workspace and the moveit is already configured with this planner? And if so didn´t you had to change anything else from that workspace? Such as other files? Regards António Matos

Sorry for the late response, I had rough past weeks. In short, you are right. I created a custom branch in my forked repo from the original one, see https://github.com/Jakubivan/moveit2/tree/ivan/humble-w-stomp

@antonio1matos
Copy link

Hi @Jakubivan. I noticed that the changes that you made in that: https://github.com/Jakubivan/moveit2/tree/ivan/humble-w-stomp was the addition of the file stomp in the package moveit_planners but you also added the file: stomp_planning.yaml to the package: moveit2/moveit_configs_utils/default_configs. Right now i have the humble branch provided in here: https://moveit.ros.org/install-moveit2/binary/ using the line code: sudo apt install ros-humble-moveit and also the moveit2_tutorials package: git clone --branch humble https://github.com/ros-planning/moveit2_tutorials from: https://moveit.picknik.ai/humble/doc/tutorials/getting_started/getting_started.html I wanted to know if the only difference between the branch that i have and the custom branch that you create in here: https://github.com/Jakubivan/moveit2/tree/ivan/humble-w-stomp is just the addition of the stomp planner or have you changed any other package from the provided branch from the moveit humble tutorials? Regards
António Matos

Copy link

github-actions bot commented Oct 9, 2024

This issue is being labeled as stale because it has been open 45 days with no activity. It will be automatically closed after another 45 days without follow-ups.

@github-actions github-actions bot added the stale Inactive issues and PRs are marked as stale and may be closed automatically. label Oct 9, 2024
Copy link

This issue was closed because it has been stalled for 45 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 25, 2024
@github-project-automation github-project-automation bot moved this to ✅ Done in MoveIt Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale Inactive issues and PRs are marked as stale and may be closed automatically.
Projects
None yet
Development

No branches or pull requests

3 participants