feat: use copier to convert structs #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
zhenjunMa
approved these changes
Sep 28, 2022
Codecov ReportBase: 60.56% // Head: 60.56% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #803 /- ##
=======================================
Coverage 60.56% 60.56%
=======================================
Files 133 133
Lines 8340 8340
=======================================
Hits 5051 5051
Misses 2712 2712
Partials 577 577 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
wenxuwan
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: seeflood [email protected]
What this PR does:
Use copier to convert structs
I used to use json marshal/unmarshal to convert requests, which is bad :(
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: