Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: example errors & ci errors #787

Merged
merged 1 commit into from
Sep 14, 2022
Merged

fix: example errors & ci errors #787

merged 1 commit into from
Sep 14, 2022

Conversation

seeflood
Copy link
Member

@seeflood seeflood commented Sep 14, 2022

Signed-off-by: seeflood [email protected]

What this PR does:
fix example errors & ci errors

Which issue(s) this PR fixes:

Fixes #757

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: seeflood <[email protected]>
@mosn-community-bot mosn-community-bot bot added bug Something isn't working cla:yes size/L labels Sep 14, 2022
@seeflood seeflood changed the title fix: examples errors fix: example errors & ci errors Sep 14, 2022
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Base: 60.56% // Head: 60.56% // No change to project coverage 👍

Coverage data is based on head (b88048c) compared to base (767f58f).
Patch has no changes to coverable lines.

❗ Current head b88048c differs from pull request most recent head 0b9bc9e. Consider uploading reports for the commit 0b9bc9e to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #787    /-   ##
=======================================
  Coverage   60.56%   60.56%           
=======================================
  Files         133      133           
  Lines        8340     8340           
=======================================
  Hits         5051     5051           
  Misses       2712     2712           
  Partials      577      577           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Xunzhuo Xunzhuo merged commit 5f65f47 into mosn:main Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The sayHello demo fails
3 participants