Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: build proxyv2 image and push it to dockerhub #655

Merged
merged 3 commits into from
Jun 17, 2022
Merged

ci: build proxyv2 image and push it to dockerhub #655

merged 3 commits into from
Jun 17, 2022

Conversation

seeflood
Copy link
Member

@seeflood seeflood commented Jun 15, 2022 •
edited
Loading

Signed-off-by: seeflood [email protected]

What this PR does:

  • build proxyv2 image
  • and then push it to dockerhub

reference:
https://mosn.io/docs/user-guide/start/istio/

todo:

  • build layotto/proxyv2:latest image with make script
  • build image in CI
  • push to dockerhub in CI

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@seeflood
build image
65875fa 
Signed-off-by: seeflood <[email protected]>
@codecov
Copy link

codecov bot commented Jun 15, 2022 •
edited
Loading

Codecov Report

Merging #655 (33b76da) into main (c232ee5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #655    /-   ##
=======================================
  Coverage   60.92%   60.92%           
=======================================
  Files         120      120           
  Lines        6377     6377           
=======================================
  Hits         3885     3885           
  Misses       2120     2120           
  Partials      372      372

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c232ee5...33b76da. Read the comment docs.

@seeflood
build image
0e6ddcd 
Signed-off-by: seeflood <[email protected]>
@seeflood
build and push image in CI
33b76da 
Signed-off-by: seeflood <[email protected]>
@seeflood seeflood changed the title [WIP]ci: build proxyv2 image and push it to dockerhub ci: build proxyv2 image and push it to dockerhub Jun 16, 2022
@seeflood seeflood requested review from Xunzhuo and a team June 16, 2022 06:12
@seeflood seeflood mentioned this pull request Jun 16, 2022
Closed
26 tasks
Xunzhuo
Xunzhuo reviewed Jun 16, 2022
View reviewed changes
Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, need to confirm that if we should add this to release pipeline?

@seeflood
Copy link
Member Author

Generally LGTM, need to confirm that if we should add this to release pipeline?

@Xunzhuo Yes we do. Since I haven't deployed the image with istio, I'm not sure if I have to modify it again.
So I want to add it in release pipeline after building up the whole istio lab

@wenxuwan wenxuwan merged commit 00a5984 into mosn:main Jun 17, 2022
@seeflood seeflood deleted the build_proxyv2 branch June 17, 2022 02:04
@seeflood seeflood mentioned this pull request Jul 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xunzhuo Xunzhuo Xunzhuo approved these changes

@wenxuwan wenxuwan wenxuwan approved these changes

Assignees
No one assigned
Labels
cla:yes dont-check-PRs-with-this-label size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seeflood @wenxuwan @Xunzhuo