Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs :translate the zh to en #581

Merged
merged 5 commits into from
May 20, 2022
Merged

docs :translate the zh to en #581

merged 5 commits into from
May 20, 2022

Conversation

NTH19
Copy link
Contributor

@NTH19 NTH19 commented May 19, 2022

What this PR does:

Which issue(s) this PR fixes:

Fixes #545

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@mosn-community-bot
Copy link

Hi @NTH19, welcome to mosn community, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

@NTH19 NTH19 changed the title translate the zh to en docs :translate the zh to en May 19, 2022
@NTH19
Copy link
Contributor Author

NTH19 commented May 19, 2022

I have already signed the CLA.

@seeflood seeflood closed this May 19, 2022
@seeflood seeflood reopened this May 19, 2022
@seeflood
Copy link
Member

seeflood commented May 19, 2022 •
edited
Loading

I have already signed the CLA.

Ok.
I closed and reopened this PR to rerun the workflow

Xunzhuo
Xunzhuo requested changes May 19, 2022
View reviewed changes
Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes, thanks @NTH19

docs/en/development/github-workflows.md Outdated Show resolved Hide resolved
docs/en/development/github-workflows.md Outdated Show resolved Hide resolved
docs/en/development/github-workflows.md Outdated Show resolved Hide resolved
docs/en/development/github-workflows.md Outdated Show resolved Hide resolved
docs/en/development/github-workflows.md Outdated Show resolved Hide resolved
docs/en/development/github-workflows.md Outdated Show resolved Hide resolved
@NTH19
Copy link
Contributor Author

NTH19 commented May 19, 2022

Some minor changes, thanks @NTH19

Is there a description file for the documentation specification ? @Xunzhuo

@Xunzhuo
Copy link
Member

Xunzhuo commented May 20, 2022

lgtm

seeflood
seeflood approved these changes May 20, 2022
View reviewed changes
Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks!

@seeflood seeflood merged commit 54f034f into mosn:main May 20, 2022
@seeflood
Copy link
Member

seeflood commented May 20, 2022 •
edited
Loading

Some minor changes, thanks @NTH19

Is there a description file for the documentation specification ? @Xunzhuo

We have a documentation contribution guide here

@NTH19 NTH19 deleted the 545_translate branch May 20, 2022 20:24
@NTH19 NTH19 restored the 545_translate branch May 20, 2022 20:24
@NTH19 NTH19 deleted the 545_translate branch May 20, 2022 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xunzhuo Xunzhuo Xunzhuo approved these changes

@seeflood seeflood seeflood approved these changes

Assignees
No one assigned
Labels
cla:yes First-time contributor size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

translate: docs/en/development/github-workflows.md to English
3 participants
@NTH19 @seeflood @Xunzhuo