Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for Dapr pubsub API #465

Merged
merged 32 commits into from
Jul 19, 2022
Merged

feat: Add support for Dapr pubsub API #465

merged 32 commits into from
Jul 19, 2022

Conversation

LXPWing
Copy link
Member

@LXPWing LXPWing commented Apr 12, 2022

What this PR does:

Re-pull request because of git conflict add Dapr pubsub API #361

@codecov
Copy link

codecov bot commented Apr 12, 2022 •
edited
Loading

Codecov Report

Merging #465 (56099c8) into main (2604d62) will decrease coverage by 0.51%.
The diff coverage is 44.37%.

❗ Current head 56099c8 differs from pull request most recent head ff6616b. Consider uploading reports for the commit ff6616b to get more accurate results

@@            Coverage Diff             @@
##             main     #465       /-   ##
==========================================
- Coverage   60.58%   60.06%   -0.52%     
==========================================
  Files         127      128        1     
  Lines        6652     6769      117     
==========================================
  Hits         4030     4066       36     
- Misses       2235     2311       76     
- Partials      387      392        5
Impacted Files Coverage Δ
pkg/grpc/dapr/dapr_api_pubsub.go 40.66% <40.66%> (ø)
pkg/grpc/dapr/dapr_api.go 58.53% <100.00%> (ø)
pkg/grpc/default_api/api_pubsub.go 32.78% <100.00%> (-9.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2604d62...ff6616b. Read the comment docs.

@seeflood seeflood closed this Apr 13, 2022
@seeflood seeflood reopened this Apr 13, 2022
@seeflood seeflood added this to the v0.5 milestone Apr 19, 2022
@seeflood
Copy link
Member

After v0.4 released , we can start reviewing and merging this PR

@seeflood seeflood mentioned this pull request May 4, 2022
Closed
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale label May 26, 2022
@seeflood
Copy link
Member

@LXPWing Hi, please resolve the conflicts so that we can continue with this PR

@LXPWing
Merge branch 'main' into feature/dapr_pubsub
d849677 
# Conflicts:
#	pkg/grpc/default_api/api_pubsub.go
@github-actions github-actions bot removed the stale label May 27, 2022
@seeflood seeflood changed the title feature: Add support for Dapr pubsub API feat: Add support for Dapr pubsub API Jun 10, 2022
seeflood
seeflood approved these changes Jul 19, 2022
View reviewed changes
Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seeflood seeflood merged commit 0e908fc into mosn:main Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhenjunMa zhenjunMa zhenjunMa approved these changes

@seeflood seeflood seeflood approved these changes

Assignees
No one assigned
Labels
area/api area/community cla:yes size/XL
Projects
None yet
Milestone
v0.5
Development

Successfully merging this pull request may close these issues.
4 participants
@LXPWing @seeflood @zhenjunMa @Xunzhuo