Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check NVM Version fails if fallback shell is used #33

Open
mirekdlugosz opened this issue May 26, 2022 · 1 comment · May be fixed by #49
Open

Check NVM Version fails if fallback shell is used #33

mirekdlugosz opened this issue May 26, 2022 · 1 comment · May be fixed by #49
Assignees
@morgangraphics
Labels
enhancement

Comments

@mirekdlugosz
Copy link

When nvm_profile is set to path that doesn't contain bash/zsh/csh/tcsh, role will fall back to setting user_shell.command to /etc/bash -ic and fail the first time it is used:

TASK [morgangraphics.ansible_role_nvm : Check NVM Version] *********************
fatal: [default]: FAILED! => {"changed": true, "cmd": "/etc/bash -ic \"nvm --version\"", "delta": "0:00:00.002488", "end": "2022-05-26 12:32:01.105866", "msg": "non-zero return code", "rc": 127, "start": "2022-05-26 12:32:01.103378", "stderr": "/bin/sh: 1: /etc/bash: not found", "stderr_lines": ["/bin/sh: 1: /etc/bash: not found"], "stdout": "", "stdout_lines": []}

I am pretty confident it should have been /bin/bash -ic.

I don't know if any distro ever shipped /etc/bash (most popular, like Ubuntu or Fedora, don't). And even if it did, it was probably some kind of configuration file, not executable.
@morgangraphics morgangraphics self-assigned this May 31, 2022
@morgangraphics
Copy link
Owner

Good catch - I'll use the default environment variable SHELL as a default instead

@morgangraphics morgangraphics linked a pull request Jun 27, 2024 that will close this issue
Feature/ansible role improvements #49
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@morgangraphics morgangraphics

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/ansible role improvements morgangraphics/ansible-role-nvm
2 participants
@morgangraphics @mirekdlugosz