Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect typedef for LinkCard #110

Open
curiousercreative opened this issue Feb 7, 2024 · 1 comment · May be fixed by #109
Open

Incorrect typedef for LinkCard #110

curiousercreative opened this issue Feb 7, 2024 · 1 comment · May be fixed by #109

Comments

@curiousercreative
Copy link

According to API documentation for card linking, the only required attribute for billingAddress is postalCode. The type definition incorrectly requires all billingAddress attributes which yields a typescript compiler error when you only supply a postalCode.
@curiousercreative curiousercreative linked a pull request Feb 7, 2024 that will close this issue
Open
@devinmarieb
Copy link
Contributor

@curiousercreative Thank you! Will have someone take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

LinkCard.billingAddress typedef fix to reflect most attributes being optional CommonEnergy/moov-node
2 participants
@curiousercreative @devinmarieb