Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Updating tools.node bundled-npm configuration docs #1605

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

iambpn
Copy link
Contributor

@iambpn iambpn commented Aug 6, 2024

Adding npm version config to use bundled npm from node instead of other version.

I've added this configuration near

[tools.node]
bundled-npm = true

Because I think they are related, and using bundled-npm = true without npm = "bundled" does not make sense.

This was missing in docs and I barely figured out this from debug-env docs, so I am making this change.

@iambpn iambpn changed the title updating node bundled-npm tool configuration docs updating tools.node bundled-npm configuration docs Aug 6, 2024
@milesj milesj enabled auto-merge (squash) August 7, 2024 07:46
@milesj milesj disabled auto-merge August 7, 2024 07:46
@milesj milesj changed the title updating tools.node bundled-npm configuration docs docs: Updating tools.node bundled-npm configuration docs Aug 7, 2024
@milesj milesj enabled auto-merge (squash) August 7, 2024 07:48
@milesj milesj merged commit 919d113 into moonrepo:master Aug 7, 2024
16 of 17 checks passed
Copy link

github-actions bot commented Aug 7, 2024

Run report for 919d1136 (ubuntu-latest, 18)

Total time: 2m 40s | Comparison time: 2m 35s | Estimated loss: 4.5s (2.8% slower)

Action Time Status Info
🟩 SyncWorkspace 26.3ms Passed
🟩 SetupToolchain(node:~18) 21.3s Passed
🟩 SyncProject(node, types) 3ms Passed
🟩 SyncProject(node, runtime) 3.4ms Passed
🟩 SyncProject(node, website) 3.3ms Passed
🟩 InstallWorkspaceDeps(node:~18) 35.2s Passed
🟦 RunTask(types:build) 909.2ms Cached
🟦 RunTask(runtime:build) 530.7ms Cached
🟩 RunTask(website:build) 1m 42s Passed
Environment

OS: Linux
Matrix:

os = ubuntu-latest
node-version = 18
Touched files
website/docs/proto/config.mdx

Copy link

github-actions bot commented Aug 7, 2024

Run report for 919d1136 (ubuntu-latest, 20)

Total time: 2m 36s | Comparison time: 2m 30s | Estimated loss: 6.3s (4.0% slower)

Action Time Status Info
🟩 SyncWorkspace 26ms Passed
🟩 SetupToolchain(node:~20) 22.6s Passed
🟩 SyncProject(node, runtime) 3.4ms Passed
🟩 SyncProject(node, types) 3.8ms Passed
🟩 SyncProject(node, website) 5.2ms Passed
🟩 InstallWorkspaceDeps(node:~20) 35s Passed
🟦 RunTask(types:build) 703.6ms Cached
🟦 RunTask(runtime:build) 415.8ms Cached
🟩 RunTask(website:build) 1m 37s Passed
Environment

OS: Linux
Matrix:

os = ubuntu-latest
node-version = 20
Touched files
website/docs/proto/config.mdx

Copy link

github-actions bot commented Aug 7, 2024

Run report for 919d1136 (windows-latest, 18)

Total time: 1m 23s | Comparison time: 2m 18s | Estimated savings: 54.5s (39.4% faster)

Action Time Status Info
🟩 SyncWorkspace 29.6ms Passed
🟩 SetupToolchain(node:~18) 26.2s Passed
🟩 SyncProject(node, runtime) 5.9ms Passed
🟩 SyncProject(node, types) 6.4ms Passed
🟩 SyncProject(node, website) 4.2ms Passed
🟩 InstallWorkspaceDeps(node:~18) 50.4s Passed
🟦 RunTask(types:build) 1.1s Cached
🟦 RunTask(runtime:build) 714.1ms Cached
🟦 RunTask(website:build) 5.5s Cached
Environment

OS: Windows
Matrix:

os = windows-latest
node-version = 18
Touched files
website/docs/proto/config.mdx

Copy link

github-actions bot commented Aug 7, 2024

Run report for 919d1136 (windows-latest, 20)

Total time: 1m 31s | Comparison time: 2m 27s | Estimated savings: 55.5s (37.7% faster)

Action Time Status Info
🟩 SyncWorkspace 29ms Passed
🟩 SetupToolchain(node:~20) 32s Passed
🟩 SyncProject(node, types) 5ms Passed
🟩 SyncProject(node, runtime) 5.5ms Passed
🟩 SyncProject(node, website) 4.1ms Passed
🟩 InstallWorkspaceDeps(node:~20) 52.2s Passed
🟦 RunTask(types:build) 975.5ms Cached
🟦 RunTask(runtime:build) 670.4ms Cached
🟦 RunTask(website:build) 5.8s Cached
Environment

OS: Windows
Matrix:

os = windows-latest
node-version = 20
Touched files
website/docs/proto/config.mdx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants