Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove noinlinephpdocs check #144

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andrewnicols
Copy link
Contributor

Replaced with moodlehq/moodle-cs#137

These checks never worked. The `get_defines()` method built a list of
definitions, added them to a `$defines` array, but return
`$this->defines` instead.

Furthermore there would be pandamonium if we actually fixed this because
we use constants in scripts all over Moodle with the same value, for
example:

```
define('CLI_SCRIPT', true);
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant