Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc: add cumul weight field to block template resp #9416

Merged
merged 1 commit into from
Aug 14, 2024
Merged

rpc: add cumul weight field to block template resp #9416

merged 1 commit into from
Aug 14, 2024
31 −24

Conversation

jeffro256
Copy link
Contributor

Resolves #9415

sneurlax
sneurlax approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@sneurlax sneurlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed changes, they look good to me. Built branch, tested response, it works.

0xFFFC0000
0xFFFC0000 approved these changes Aug 5, 2024
View reviewed changes
Copy link
Collaborator

@0xFFFC0000 0xFFFC0000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luigi1111 luigi1111 merged commit a1dc85c into monero-project:master Aug 14, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sneurlax sneurlax sneurlax approved these changes

@0xFFFC0000 0xFFFC0000 0xFFFC0000 approved these changes

Assignees
No one assigned
Labels
daemon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose Expected Block Size to get_block_template RPC
4 participants
@jeffro256 @sneurlax @0xFFFC0000 @luigi1111