Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ZMQ DaemonInfo [0.18 release] #9385

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Fix ZMQ DaemonInfo [0.18 release] #9385

merged 1 commit into from
Aug 13, 2024

Conversation

vtnerd
Copy link
Contributor

@vtnerd vtnerd commented Jun 25, 2024

  • top_block_hash was never set in handler
  • wide_difficulty was never sent in JSON
  • wide_cumulative_difficulty was never sent in JSON

@vtnerd
Fix ZMQ DaemonInfo:
c5ad937 
  * top_block_hash was never set in handler
  * wide_difficulty was never sent in JSON
  * wide_cumulative_difficulty was never sent in JSON
@vtnerd
Copy link
Contributor Author

vtnerd commented Jun 25, 2024

Despite the failed tests, things look good. The macOS test requires a separate PR to fix Boost includes, and the test failure was the usual race_condition test that fails spuriously.

0xFFFC0000
0xFFFC0000 approved these changes Aug 5, 2024
View reviewed changes
Copy link
Collaborator

@0xFFFC0000 0xFFFC0000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already approved the #9384.

About the failures:

build-windows:

D:/a/_temp/msys64/mingw64/include/absl/base/policy_checks.h:79:2: error: #error "C   versions less than C  14 are not supported."
   79 | #error "C   versions less than C  14 are not supported."

Which is already fixed, and is not related to this PR.
build-macos:

/opt/homebrew/include/absl/base/policy_checks.h:79:2: error: "C   versions less than C  14 are not supported."
#error "C   versions less than C  14 are not supported."

Already fixed and not related to this PR.

And test-ubuntu was:

[ RUN      ] node_server.race_condition
terminate called without an active exception

which is not related to the PR.

Thanks.

@luigi1111 luigi1111 merged commit bedfa83 into monero-project:release-v0.18 Aug 13, 2024
14 of 17 checks passed
@hundehausen hundehausen mentioned this pull request Aug 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFFFC0000 0xFFFC0000 0xFFFC0000 approved these changes

@SChernykh SChernykh SChernykh approved these changes

Assignees
No one assigned
Labels
daemon pending review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vtnerd @SChernykh @0xFFFC0000 @selsta @luigi1111