⭐️ allow and deny subscriptions scan VMs options #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds three more flags to the experimental command `cnspec integrate azure`. `--allow`, `--deny` used to control the integration of subscriptions. `--scan-vms` that enables scanning VMs on Azure subscriptions via RunCommand. Additionally, I moved the `onboarding` code that is generic to its own package so that new integration commands like `gcp` or `aws` can leverage it. Signed-off-by: Salim Afiune Maya <[email protected]>
jaym
reviewed
Nov 13, 2024
internal/onboarding/exec.go
Outdated
| if err := TerraformExecApply(tf); err != nil { | ||
| return errors.New(provideGuidanceAfterFailure(err, tf.WorkingDir(), tf.ExecPath())) | ||
| } | ||
| vw.Close() |
There was a problem hiding this comment.
is it an issue if these are not closed on error?
There was a problem hiding this comment.
Good question.
There is no issue, but I think it is nice to clear the terminal since we are extracting the error and presenting it to the user, this way it won't be duplicate.
jaym
approved these changes
Nov 13, 2024
Signed-off-by: Salim Afiune Maya <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds three more flags to the experimental command
cnspec integrate azure.--allow,--denyused to control the integration of subscriptions. By default, all subscriptions will be discovered and integrated for continuous scanning.To choose the subscriptions to scan, pass the list of subscriptions using the
--allowflag.To scan all subscriptions expect those you specify, pass the list of subscriptions you don't
want Mondoo to scan using the
--denyflag.The new
--scan-vmsenables scanning VMs on Azure subscriptions via RunCommand.NOTE that --allow and --deny are mutually exclusive and can't be use together.
Finally, I moved the
onboardingcode that is generic to its own package so that new integration commands likegcporawscan leverage it.