[bugfix] isBetween should return false for invalid dates #4417
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to
isBetween
to fix a couple of issues from #4416 and #4114 .Documentation states that
invalid.isBetween(another, another)
should returnfalse
, but #4416 highlights a case where it doesn't. This PR fixes #4416 and ensuresisBetween(..)
returnfalse
no matter what unit or inclusivity flags are used:The conversation in #4114 highlights some examples that are incompatible with current typescript bindings. This PR fixes the typescript binding to match example code - explicitly allowing
null
to be passed in as theunits
value, - and this now follows a faster code path to avoid cloning moments unnecessarily - i.e. fixes #4114.