Codegen new intrinsic raw_eq
#331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedinski
approved these changes
Jul 15, 2021
Comment on lines
675
to
677
| // TODO: Handle more cases in this intrinsic by looking into the parameters' layouts. | ||
| // TODO: Fix soundness issues in this intrinsic. It's UB to call `raw_eq` if any of | ||
| // the bytes in the first or second arguments are uninitialized. |
There was a problem hiding this comment.
Are there things we could assert on here? Or for the first TODO would it already crash in the unhandled cases?
There was a problem hiding this comment.
The soundness check has to come in before the rest of the code. Then you can decide based on layouts and finally use memcmp for the general case. The cranelift backend does this.
This was referenced Jul 15, 2021
adpaco-aws
added a commit
that referenced
this pull request
Jul 26, 2021
adpaco-aws
added a commit
that referenced
this pull request
Aug 2, 2021
adpaco-aws
added a commit
that referenced
this pull request
Aug 6, 2021
adpaco-aws
added a commit
that referenced
this pull request
Aug 17, 2021
adpaco-aws
added a commit
that referenced
this pull request
Aug 24, 2021
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 22, 2022
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 25, 2022
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This allows us to codegen the intrinsic
raw_eqwhich has been introduced in the latest rebase. See #292 for the report.Resolved issues:
Resolves #330
Unblocks #292
Call-outs:
Codegen can be improved to avoid calling
memcmpin some cases.Testing:
How is this change tested? Existing regression plus one new test for this intrinsic.
Is this a refactor change? No.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.