Add RMC workflow file for GitHub Actions #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adpaco-aws
force-pushed
the
rmc-ci
branch
4 times, most recently
from
c164405
to
0646403
Compare
adpaco-aws
force-pushed
the
rmc-ci
branch
7 times, most recently
from
360631d
to
18e7517
Compare
adpaco-aws
added
the
[C] Internal
danielsn
suggested changes
Apr 14, 2021
scripts/setup/install_cbmc.sh
Outdated
| @@ -0,0 1,4 @@ | |||
| # Install CBMC 5.27 | |||
There was a problem hiding this comment.
needs a copyright notice.
There was a problem hiding this comment.
Do we need it also in the other scripts and the workflow file?
scripts/setup/install_cbmc.sh
Outdated
| @@ -0,0 1,4 @@ | |||
| # Install CBMC 5.27 | |||
There was a problem hiding this comment.
These are ubuntu only. Either name them as such, or put them in an ubuntu folder
scripts/setup/install_ubuntu_deps.sh
Outdated
| @@ -0,0 1,22 @@ | |||
| # Install tools via `apt-get` | |||
There was a problem hiding this comment.
Do we have an ubuntu version requirement here? If so, make that explicit
There was a problem hiding this comment.
Yes, this is supposed to work for Ubuntu 20.04.
scripts/setup/prepare_config_toml.sh
Outdated
| @@ -0,0 1,8 @@ | |||
| # Use config.toml template and set debugging options | |||
There was a problem hiding this comment.
Why don't we just set these in the example config.toml
There was a problem hiding this comment.
Some users may not want to do development work and just use the release version. In that case, we would have a different script for it.
There was a problem hiding this comment.
Maybe have a config.toml.development and config.toml.release?
There was a problem hiding this comment.
Modify the README.md to point tho this?
There was a problem hiding this comment.
Yes. Can we leave it for another PR? It's not necessary here, and have other changes in mind for it.
adpaco-aws
commented
Apr 14, 2021
Comment on lines
1
to
2
| # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 OR MIT |
There was a problem hiding this comment.
Is the copyright needed in this file?
danielsn
suggested changes
Apr 14, 2021
scripts/setup/install_llvm.sh
Outdated
| @@ -0,0 1,12 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Should this move under the ubuntu folder?
There was a problem hiding this comment.
I don't think so. It can be used in other systems, right?
There was a problem hiding this comment.
#!/bin/bash
################################################################################
# Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
# See https://llvm.org/LICENSE.txt for license information.
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
################################################################################
#
# This script will install the llvm toolchain on the different
# Debian and Ubuntu versions
set -eux
danielsn
reviewed
Apr 14, 2021
scripts/setup/install_llvm.sh
Outdated
Comment on lines
4
to
6
| set -x | ||
| set -e | ||
| set -u |
There was a problem hiding this comment.
Actually, set -eux is cleaner
scripts/setup/install_llvm.sh
Outdated
| @@ -0,0 1,12 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
#!/bin/bash
################################################################################
# Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
# See https://llvm.org/LICENSE.txt for license information.
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
################################################################################
#
# This script will install the llvm toolchain on the different
# Debian and Ubuntu versions
set -eux
danielsn
approved these changes
Apr 14, 2021
adpaco-aws
added a commit
that referenced
this pull request
Apr 16, 2021
* Add RMC workflow file for GitHub Actions * Add multiple setup scripts used by workflow * Improvements for Actions worflow and setup scripts
adpaco-aws
added a commit
that referenced
this pull request
Apr 26, 2021
* Add RMC workflow file for GitHub Actions * Add multiple setup scripts used by workflow * Improvements for Actions worflow and setup scripts
adpaco-aws
added a commit
that referenced
this pull request
May 5, 2021
* Add RMC workflow file for GitHub Actions * Add multiple setup scripts used by workflow * Improvements for Actions worflow and setup scripts
adpaco-aws
added a commit
that referenced
this pull request
May 10, 2021
* Add RMC workflow file for GitHub Actions * Add multiple setup scripts used by workflow * Improvements for Actions worflow and setup scripts
adpaco-aws
added a commit
that referenced
this pull request
May 26, 2021
* Add RMC workflow file for GitHub Actions * Add multiple setup scripts used by workflow * Improvements for Actions worflow and setup scripts
adpaco-aws
added a commit
that referenced
this pull request
Jun 1, 2021
* Add RMC workflow file for GitHub Actions * Add multiple setup scripts used by workflow * Improvements for Actions worflow and setup scripts
adpaco-aws
added a commit
that referenced
this pull request
Jun 7, 2021
* Add RMC workflow file for GitHub Actions * Add multiple setup scripts used by workflow * Improvements for Actions worflow and setup scripts
adpaco-aws
added a commit
that referenced
this pull request
Jun 17, 2021
* Add RMC workflow file for GitHub Actions * Add multiple setup scripts used by workflow * Improvements for Actions worflow and setup scripts
adpaco-aws
added a commit
that referenced
this pull request
Jun 23, 2021
* Add RMC workflow file for GitHub Actions * Add multiple setup scripts used by workflow * Improvements for Actions worflow and setup scripts
adpaco-aws
pushed a commit
that referenced
this pull request
Jul 2, 2021
New lint: `disallowed_script_idents` This PR implements a new lint to restrict locales that can be used in the code, as proposed in #7376. Current concerns / unresolved questions: - ~~Mixed usage of `script` (as a Unicode term) and `locale` (as something that is easier to understand for the broad audience). I'm not sure whether these terms are fully interchangeable and whether in the current form it is more confusing than helpful.~~ `script` is now used everywhere. - ~~Having to mostly copy-paste `AllowedScript`. Probably it's not a big problem, as the list of scripts is standardized and is unlikely to change, and even if we'd stick to the `unicode_script::Script`, we'll still have to implement custom deserialization, and I don't think that it will be shorter in terms of the amount of LoC.~~ `unicode::Script` is used together with a filtering deserialize function. - Should we stick to the list of "recommended scripts" from [UAX #31](http://www.unicode.org/reports/tr31/#Table_Recommended_Scripts) in the configuration? *Please write a short comment explaining your change (or "none" for internal only changes)* changelog: ``[`disallowed_script_idents`]`` r? `@Manishearth`
adpaco-aws
added a commit
that referenced
this pull request
Jul 2, 2021
* Add RMC workflow file for GitHub Actions * Add multiple setup scripts used by workflow * Improvements for Actions worflow and setup scripts
adpaco-aws
added a commit
that referenced
this pull request
Jul 9, 2021
* Add RMC workflow file for GitHub Actions * Add multiple setup scripts used by workflow * Improvements for Actions worflow and setup scripts
adpaco-aws
added a commit
that referenced
this pull request
Jul 15, 2021
* Add RMC workflow file for GitHub Actions * Add multiple setup scripts used by workflow * Improvements for Actions worflow and setup scripts
adpaco-aws
added a commit
that referenced
this pull request
Jul 26, 2021
* Add RMC workflow file for GitHub Actions * Add multiple setup scripts used by workflow * Improvements for Actions worflow and setup scripts
adpaco-aws
added a commit
that referenced
this pull request
Aug 2, 2021
* Add RMC workflow file for GitHub Actions * Add multiple setup scripts used by workflow * Improvements for Actions worflow and setup scripts
adpaco-aws
added a commit
that referenced
this pull request
Aug 6, 2021
* Add RMC workflow file for GitHub Actions * Add multiple setup scripts used by workflow * Improvements for Actions worflow and setup scripts
adpaco-aws
added a commit
that referenced
this pull request
Aug 17, 2021
* Add RMC workflow file for GitHub Actions * Add multiple setup scripts used by workflow * Improvements for Actions worflow and setup scripts
adpaco-aws
added a commit
that referenced
this pull request
Aug 24, 2021
* Add RMC workflow file for GitHub Actions * Add multiple setup scripts used by workflow * Improvements for Actions worflow and setup scripts
celinval
referenced
this pull request
in celinval/kani-dev
Nov 16, 2021
Use xor to implement Neg::neg for floats
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 22, 2022
* Add RMC workflow file for GitHub Actions * Add multiple setup scripts used by workflow * Improvements for Actions worflow and setup scripts
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 25, 2022
* Add RMC workflow file for GitHub Actions * Add multiple setup scripts used by workflow * Improvements for Actions worflow and setup scripts
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
* Add RMC workflow file for GitHub Actions * Add multiple setup scripts used by workflow * Improvements for Actions worflow and setup scripts
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
* Add RMC workflow file for GitHub Actions * Add multiple setup scripts used by workflow * Improvements for Actions worflow and setup scripts
danielsn
pushed a commit
to danielsn/kani
that referenced
this pull request
May 11, 2022
* Add RMC workflow file for GitHub Actions * Add multiple setup scripts used by workflow * Improvements for Actions worflow and setup scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR adds
rmc.ymlin.github/workflows/scripts/setup/to enable regression testing using GitHub Actions.
The workflow will run on
pushandpull_requestchanges using Ubuntu 20.04. We can extend this workflow to run on macOs or other systems in the future.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.