Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix types for codegen of intrinsic const #268

Merged
merged 3 commits into from
Jun 25, 2021
Merged

Fix types for codegen of intrinsic const #268

merged 3 commits into from
Jun 25, 2021

Conversation

avanhatt
Copy link
Contributor

@avanhatt avanhatt commented Jun 25, 2021 •
edited
Loading

Description of changes:

For generating intrinsic constants, we were using a default size_t type and casting to the expected type. We should just codegen the right type.

Resolved issues:

Resolves #265

Call-outs:

None!

Testing:

  • How is this change tested?

New regression test.

  • Is this a refactor change?

No.

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@danielsn
Copy link
Contributor

Nice!

@danielsn danielsn merged commit dc073e5 into model-checking:main-153-2021-06-23 Jun 25, 2021
adpaco-aws pushed a commit that referenced this pull request Jul 2, 2021
@avanhatt @adpaco-aws
Fix types for codegen of intrinsic const (#268)
5f22818
@avanhatt avanhatt mentioned this pull request Jul 6, 2021
Closed
5 tasks
adpaco-aws pushed a commit that referenced this pull request Jul 9, 2021
@avanhatt @adpaco-aws
Fix types for codegen of intrinsic const (#268)
9e0ca08
adpaco-aws pushed a commit that referenced this pull request Jul 15, 2021
@avanhatt @adpaco-aws
Fix types for codegen of intrinsic const (#268)
43cbd93
adpaco-aws pushed a commit that referenced this pull request Jul 26, 2021
@avanhatt @adpaco-aws
Fix types for codegen of intrinsic const (#268)
c75008f
adpaco-aws pushed a commit that referenced this pull request Aug 2, 2021
@avanhatt @adpaco-aws
Fix types for codegen of intrinsic const (#268)
3f0e7c7
@zhassan-aws zhassan-aws mentioned this pull request Aug 6, 2021
Closed
4 tasks
adpaco-aws pushed a commit that referenced this pull request Aug 6, 2021
@avanhatt @adpaco-aws
Fix types for codegen of intrinsic const (#268)
48940d7
adpaco-aws pushed a commit that referenced this pull request Aug 17, 2021
@avanhatt @adpaco-aws
Fix types for codegen of intrinsic const (#268)
729f54e
adpaco-aws pushed a commit that referenced this pull request Aug 24, 2021
@avanhatt @adpaco-aws
Fix types for codegen of intrinsic const (#268)
4cc2905
@avanhatt avanhatt deleted the intrinsic_cast branch September 14, 2021 15:25
tedinski pushed a commit to tedinski/rmc that referenced this pull request Apr 22, 2022
@avanhatt @tedinski
Fix types for codegen of intrinsic const (model-checking#268)
a7e245c
tedinski pushed a commit to tedinski/rmc that referenced this pull request Apr 25, 2022
@avanhatt @tedinski
Fix types for codegen of intrinsic const (model-checking#268)
40d9d0c
tedinski pushed a commit to tedinski/rmc that referenced this pull request Apr 26, 2022
@avanhatt @tedinski
Fix types for codegen of intrinsic const (model-checking#268)
e921f49
tedinski pushed a commit that referenced this pull request Apr 27, 2022
@avanhatt @tedinski
Fix types for codegen of intrinsic const (#268)
aa9a812
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielsn danielsn danielsn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to codegen micro-http crate
2 participants
@avanhatt @danielsn