fix: support errors with circular dependencies in object values with --parallel #5212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
breakCircularDepsbreaks the reporter inparallelmode withallow-uncaught#5188; fixes 🐛 Bug: infinite loop in parallel tests with uncaught error containing circular dependency #5209status: accepting prsOverview
Only calling
breakCircularDepsonresult.errormeans any circular references in other properties ofresultstill go through.SerializableEvent._serializecan generally visit them fine, but they still end up being infinitely added topairs. This PR adds aseenPairsSetto make sure they only get serialized once each. This fixes #5209.Also only writes to properties with
.writableobject descriptors. This fixes #5188.