[27.x backport] build: create distinct history db for each store #48688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CrazyMax <[email protected]> (cherry picked from commit 58f4e91) Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
area/builder
status/2-code-review
area/builder/buildkit
thaJeztah
changed the title
austinvazquez
approved these changes
Oct 17, 2024
vvoland
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Update build controller logic so it"s using a distinct db for each type of store:
history.dbfor graphdriverhistory_c8d.dbfor containerd snapshotterAs follow-up in BuildKit we should prune records that have missing blobs.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)