[27.x backport] integration/build: remove TestBuildWithSession, and fsutil direct dependency #48630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endency This test was originally used to test the experimental `--stream` option with the classic builder. This feature was removed in Docker 20.10 through 6ca3ec8, which also disabled the test (adding a note to rewrite the test for BuildKit). The above is 5 years ago, and we now run the BuildKit integration tests as part of our CI, which (I assume) should cover this functionality. Removing this test, as it depends on github.com/tonistiigi/fsutil, which does not have a stable API, and frequently cannot be updated independently from BuildKit. Also adding a linter-rule to prevent it from accidentally being imported; errdefs/defs.go:3:8: import 'github.com/tonistiigi/fsutil' is not allowed from list 'main': The fsutil module does not have a stable API, so we should not have a direct dependency unless necessary. (depguard) import _ "github.com/tonistiigi/fsutil" ^ Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit 7fa6d3c) Signed-off-by: Sebastiaan van Stijn <[email protected]>
laurazard
approved these changes
Oct 10, 2024
thaJeztah
deleted the
27.x_backport_integration_remove_TestBuildWithSession
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was originally used to test the experimental
--streamoption with the classic builder. This feature was removed in Docker 20.10 through 6ca3ec8, which also disabled the test (adding a note to rewrite the test for BuildKit).The above is 5 years ago, and we now run the BuildKit integration tests as part of our CI, which (I assume) should cover this functionality.
Removing this test, as it depends on github.com/tonistiigi/fsutil, which does not have a stable API, and frequently cannot be updated independently from BuildKit.
Also adding a linter-rule to prevent it from accidentally being imported;