Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix avatar and sound selection (Broken since v1.9.0) #83

Merged
merged 1 commit into from
Nov 14, 2019

Conversation

dignite
Copy link

@dignite dignite commented Nov 14, 2019

This was due to a breaking change in electron v6 with dialog.showOpenDialog.

This was a breaking change in electron v6
@coveralls
Copy link

Pull Request Test Coverage Report for Build 686

  • 0 of 11 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.07%) to 44.606%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/windows/config/index.js 0 11 0.0%
Totals Coverage Status
Change from base Build 682: -0.07%
Covered Lines: 237
Relevant Lines: 528

💛 - Coveralls

@dignite dignite merged commit f524560 into master Nov 14, 2019
@dignite dignite deleted the fix-avatar-selection-since-electron-6 branch November 14, 2019 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants