Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout timer window with css grid #50

Merged
merged 4 commits into from
Jun 7, 2019
Merged

Layout timer window with css grid #50

merged 4 commits into from
Jun 7, 2019

Conversation

dignite
Copy link

@dignite dignite commented Jun 5, 2019

As a developer
In order to have more control over the layout of timer window
I want the layout to be based on css grid with named areas

This could be good when for example deciding on different sizes for the timer window.

@coveralls
Copy link

coveralls commented Jun 5, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 292

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 35.119%
Totals Coverage Status
Change from base Build 280: 0.0%
Covered Lines: 171
Relevant Lines: 514
💛 - Coveralls

niklas-r
niklas-r approved these changes Jun 7, 2019
View reviewed changes
Copy link

@niklas-r niklas-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about CSS grids sadly so I can' t give you much in constructive feedback other than I believe this is a good idea :)

@dignite dignite merged commit 521fbfc into master Jun 7, 2019
@dignite dignite deleted the css-grid branch June 7, 2019 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklas-r niklas-r niklas-r approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dignite @coveralls @niklas-r