Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase config window size #43

Merged
merged 8 commits into from
May 31, 2019
Merged

Increase config window size #43

merged 8 commits into from
May 31, 2019

Conversation

dignite
Copy link

@dignite dignite commented May 26, 2019 •
edited
Loading

As a user of mob timer
In order to have a better experience
I want the timer window to be a bit higher and not have scroll by default

As a developer
In order to optimize for deletion and to have higher cohesion
I want the knowledge about config window creation to be in the config folder

What

  • Move new BrowserWindow call and other config window relate things into config/initialize.js
  • Increase initial height of config window to fit all settings and up to three mobbers.

@coveralls
Copy link

coveralls commented May 26, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 219

  • 0 of 19 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 35.788%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/windows/windows.js 0 3 0.0%
src/windows/config/initialize.js 0 16 0.0%
Totals Coverage Status
Change from base Build 215: -0.2%
Covered Lines: 178
Relevant Lines: 521
💛 - Coveralls

@dignite dignite changed the title WIP Increase config window size Increase config window size May 27, 2019
niklas-r
niklas-r approved these changes May 28, 2019
View reviewed changes
Copy link

@niklas-r niklas-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR fulfills what you wanted to achieve. When #44 is merged we could add some tests as you said and refactor some parts, maybe we could avoid using let?

@dignite
Copy link
Author

dignite commented May 28, 2019

I think this PR fulfills what you wanted to achieve. When #44 is merged we could add some tests as you said and refactor some parts, maybe we could avoid using let?

Not sure if we can avoid using let since we want to re-assign the variable (to null) when the window closes, but I can have a look.

@dignite dignite merged commit ed113e1 into master May 31, 2019
@dignite dignite deleted the increase-config-window-size branch May 31, 2019 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklas-r niklas-r niklas-r approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dignite @coveralls @niklas-r