Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add steps to implement GC to porting guide #1016

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

k-sareen
Copy link
Collaborator

@k-sareen k-sareen commented Nov 6, 2023

No description provided.

@k-sareen k-sareen marked this pull request as draft November 6, 2023 04:55
@k-sareen
Copy link
Collaborator Author

@k-sareen: Reminder to talk about flushing mutator buffers before GC (including destroyed mutators)

@qinsoon
Copy link
Member

qinsoon commented Dec 14, 2023

@k-sareen: Reminder to talk about flushing mutator buffers before GC (including destroyed mutators)

#1047 suggested that the binding should not need to flush mutator explicitly, i.e. the binding should call destroy_mutator but not flush_mutator. The contract is that the binding should let MMTk know when a mutator thread dies, and MMTk deals with whatever needs to be done with the mutator (e.g. flushing thread local states).

@k-sareen
Copy link
Collaborator Author

@qinsoon This is the PR I was talking about. It's a bit outdated now I think it we don't have the coordinator thread anymore, for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants