Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Persist ExperimentListView hidden status in uiState #13299

Closed
wants to merge 3 commits into from

Conversation

Multihuntr
Copy link

@Multihuntr Multihuntr commented Oct 2, 2024

I added experimentListHidden to ExperimentPageUIState model. Then I changed ExperimentListView from class into functional React component in order to be able to use hooks and copied the method to load/save uiState from ExperimentView into ExperimentListView.

WIP because there's some problems. @daniellok-db can I get a hand with this? Do you approve of the approach? It seems like a lot of work for a relatively simple change, but I couldn't think of another way to do it.

  1. The uiState is not being persisted correctly. For some reason, on page refresh the default value is being written to disk before it reaches ExperimentListView. I don't know why.
  2. The component is being re-rendered more than it was. I don't know if this is a problem with the functional interface, but including those hooks causes several extra calls.
  3. The Edit and Delete modals aren't being displayed. I haven't looked into it; I assume that's related to my change to a functional component.
  4. I couldn't figure out what one part of the code was supposed to do. There's a part that calls list.forceUpdateGrid(), but the list ref doesn't seem to have that function when I change to functional useRef way of doing things.
  5. I haven't run tests on it yet, since I don't know if this is the right way to go about it, and I know there's problems.

Related Issues/PRs

#13253

What changes are proposed in this pull request?

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/deployments: MLflow Deployments client APIs, server, and third-party Deployments integrations
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/recipes: Recipes, Recipe APIs, Recipe configs, Recipe Templates
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Bug fixes, doc updates and new features usually go into minor releases.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Bug fixes and doc updates usually go into patch releases.
  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

…tilise the hooks for uiState. Added experimentViewHidden to ExperimentPageUIState model. Used uiState for showing/hiding experimentListView. PROBLEMS: 1. The uiState is not being persisted correctly. 2. The component is being re-rendered more than it was. 3. The list ref forceUpdateGrid() doesn't work anymore.
Copy link

github-actions bot commented Oct 2, 2024

@Multihuntr Thank you for the contribution! Could you fix the following issue(s)?

⚠ DCO check

The DCO check failed. Please sign off your commit(s) by following the instructions here. See https://github.com/mlflow/mlflow/blob/master/CONTRIBUTING.md#sign-your-work for more details.

⚠ PR branch check

This PR was filed from the master branch in your fork, which is not recommended and may cause our CI checks to fail. Please close this PR and file a new PR from a non-master branch.

Copy link

github-actions bot commented Oct 2, 2024

Documentation preview for 3cd838e will be available when this CircleCI job
completes successfully.

More info

@github-actions github-actions bot added the area/uiux Front-end, user experience, plotting, JavaScript, JavaScript dev server label Oct 2, 2024
Multihuntr and others added 2 commits October 7, 2024 19:02
…ys which are regenerated. But actually, I didn't like that and made it dynamic.
@Multihuntr Multihuntr closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/uiux Front-end, user experience, plotting, JavaScript, JavaScript dev server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant