Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking right arrow on the last step of the tour loops the segment #203

Closed
isaisabel opened this issue Jul 9, 2020 · 0 comments
Closed

Clicking right arrow on the last step of the tour loops the segment #203

isaisabel opened this issue Jul 9, 2020 · 0 comments
Assignees
@isaisabel
Labels
bug Something isn't working timescale/imminent Ready to be assigned to developers
Milestone
Version 2.1.2

Comments

@isaisabel
Copy link
Contributor

Going to /resources/versions/?tour=true and clicking right arrow repeatedly to get to the last step of the tour will cause the segment to loop (restart the versions segment after the last step) instead of sending the user back to the site index page.

This is probably a bug with the URL of the last step, which is dependant on the base_url from settings.js.
@isaisabel isaisabel added the bug Something isn't working label Jul 9, 2020
@isaisabel isaisabel added this to the Version 2.1.2 milestone Jul 9, 2020
@isaisabel isaisabel added the timescale/imminent Ready to be assigned to developers label Jul 9, 2020
@isaisabel isaisabel self-assigned this Jul 9, 2020
@isaisabel isaisabel mentioned this issue Jul 9, 2020
Merged
isaisabel added a commit that referenced this issue Jul 9, 2020
@isaisabel
Merge pull request #211 from mitre-attack/fix/#203-tour-segment-loop
be2d158 
Fix tour loop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@isaisabel isaisabel

Labels
bug Something isn't working timescale/imminent Ready to be assigned to developers
Projects
None yet
Milestone
Version 2.1.2
Development

No branches or pull requests
1 participant
@isaisabel