Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tier update: return a better error when incorrect credentials or other error encountered #20034

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

marktheunissen
Copy link
Contributor

…p fails for tier

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

We currently return Specified tier type is unsupported when actually the tier might be supported, just the credentials are wrong or some other problem has occurred. This adds another error type with the message Failed to setup remote tier, check credentials so that mc returns this:

❯ ./mc ilm tier update ...wrong creds...
mc: <ERROR> Unable to edit remote tier. Failed to setup remote tier, check credentials.

We could even expand this to be even more specific or return actual error, if anyone thinks it should be done?

Motivation and Context

How to test this PR?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@marktheunissen marktheunissen changed the title Return a better error when incorrect credentials are provided or setu… Tier update: return a better error when incorrect credentials or other error encountered Jul 3, 2024
cmd/warm-backend.go Outdated Show resolved Hide resolved
cmd/tier.go Outdated Show resolved Hide resolved
cmd/tier.go Outdated Show resolved Hide resolved
cmd/tier.go Outdated Show resolved Hide resolved
cmd/warm-backend.go Outdated Show resolved Hide resolved
Co-authored-by: Harshavardhana <[email protected]>
@harshavardhana harshavardhana merged commit 88926ad into minio:master Jul 3, 2024
20 checks passed
@marktheunissen marktheunissen deleted the tiersetuperror branch July 3, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants