Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the Execution Logic for the Popularity Recommender Integration #9529

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Fixed the Execution Logic for the Popularity Recommender Integration #9529

merged 2 commits into from
Jul 30, 2024

Conversation

MinuraPunchihewa
Copy link
Contributor

@MinuraPunchihewa MinuraPunchihewa commented Jul 23, 2024 •
edited

Description

Please include a summary of the change and the issue it solves.

Fixes #9528

Type of change

  • 🐛 Bug fix (non-breaking change which fixes an issue)

Verification Process

To ensure the changes are working as expected:

  • Test Location: Specify the URL or path for testing.
  • Verification Steps: Outline the steps or queries needed to validate the change. Include any data, configurations, or actions required to reproduce or see the new functionality.

Additional Media:

  • I have attached a brief loom video or screenshots showcasing the new functionality or change.

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

@MinuraPunchihewa MinuraPunchihewa marked this pull request as ready for review July 25, 2024 07:36
@MinuraPunchihewa
Copy link
Contributor Author

MinuraPunchihewa commented Jul 25, 2024 •
edited

Hey @dusvyat,
I've made some small changes to fix the Population Recommender engine in this PR (this fixes create()), however, I noticed that predict() does not run successfully because an error pops up at this line. The reason, from what I have gathered, is that the is_in() function cannot be used on a list column, which is what 'popular_items' is. Do you have any suggestions for how this can be resolved? Since this is a LazyFrame, some of the options I tried such as using map_rows() with a function to filter the rows did not work.

dusvyat
dusvyat approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@dusvyat dusvyat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MinuraPunchihewa
Copy link
Contributor Author

Hey @dusvyat,
Let me know what you think of the comment I have left above.

@ZoranPandovski
Copy link
Member

@MinuraPunchihewa Let's open new issue for this and solve it in another PR

@ZoranPandovski ZoranPandovski merged commit 535864b into main Jul 30, 2024
14 checks passed
@ZoranPandovski ZoranPandovski deleted the bugfix/fix_pop_rec branch July 30, 2024 13:22
@MinuraPunchihewa
Copy link
Contributor Author

@ZoranPandovski Understood. I will create an issue now.

@MinuraPunchihewa MinuraPunchihewa mentioned this pull request Jul 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dusvyat dusvyat dusvyat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Popularity Recommender - ColumnNotFoundError: counts
3 participants
@MinuraPunchihewa @ZoranPandovski @dusvyat