Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Integration] Financial Modeling Prep Api Integration #9427

Merged
merged 131 commits into from
Oct 28, 2024
Merged

[Integration] Financial Modeling Prep Api Integration #9427

merged 131 commits into from
Oct 28, 2024

Conversation

RiyanaD
Copy link
Contributor

@RiyanaD RiyanaD commented Jul 1, 2024 •
edited
Loading

Description

Implemented key features of the financial modeling prep api integration, including connecting to the financial modeling api, querying database and loading daily chart stock information for a specific symbol, and the limit feature which loads only a certain amount of data points. Created a read-me for these features and wrote tests to validate these basic functionalities.

Fixes #5525

Type of change

  • ⚡ New feature (non-breaking change which adds functionality)

Verification Process

To ensure the changes are working as expected:

  • Run tests: python -m unittest discover -s mindsdb/integrations/handlers/financial_modeling_prep_handler/tests

Additional Media:

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

@RiyanaD
init
7010d68
@RiyanaD
initialized financial prep handler files
2b6af3f
@RiyanaD
set up handler.py
b28b29c
@RiyanaD
handler set up
8863e73
@RiyanaD
initialized tests files
da24415
@RiyanaD
set up constructor and api key field
b87bccf
@RiyanaD
set up client and connection
983c3e9
@RiyanaD
added native_query method
5a86415
@RiyanaD
daily chart endpoint
61f2812
@RiyanaD
set up financial modeling table class
f7b8348
@RiyanaD
---
d469c13
@RiyanaD
updated get_daily_chart method
531c6d6
@RiyanaD
parsing daily chart data
a34c05c
@RiyanaD
updates to table class
8bc89ce
@RiyanaD
switched to request lib
9991a55
@RiyanaD
register table
9630867
@RiyanaD
parsing params from conditions
2558679
@RiyanaD
--
38de0df
@RiyanaD
updated select method
6d77332
@RiyanaD
--
6605ef4
@RiyanaD
testing get daily chart method
ffcd4cf
@RiyanaD
set up test file
3f87e97
@RiyanaD
testing get daily chart
7541a38
@RiyanaD
request lib
1049b5d
@RiyanaD
get daily chart working
bde3090
@RiyanaD
updated readme
f5a921f
@RiyanaD
updates
9006065
@RiyanaD
fixed get daily chart
13cb71d
@RiyanaD
fixed init.py
219500e
@RiyanaD
about.py
cf99032
@RiyanaD
Copy link
Contributor Author

RiyanaD commented Oct 17, 2024

I have read the CLA Document and I hereby sign the CLA.

mindsdbadmin added a commit that referenced this pull request Oct 21, 2024
@mindsdbadmin
@MinuraPunchihewa has signed the CLA in #9427
b2296e1
MinuraPunchihewa
MinuraPunchihewa requested changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@MinuraPunchihewa MinuraPunchihewa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Riyana,
I left one last comment (I think this will be my last), but you still have a bunch of lint issues that need to be resolved/

mindsdb/integrations/handlers/financial_modeling_prep_handler/financial_modeling_handler.py Outdated Show resolved Hide resolved
@RiyanaD
Copy link
Contributor Author

RiyanaD commented Oct 23, 2024

Hi Riyana, I left one last comment (I think this will be my last), but you still have a bunch of lint issues that need to be resolved/

The line numbers changed while I was editing the files which caused some lint issues to be missed, but everything should be fixed now!

MinuraPunchihewa
MinuraPunchihewa reviewed Oct 23, 2024
View reviewed changes
Copy link
Contributor

@MinuraPunchihewa MinuraPunchihewa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @RiyanaD,
Unfortunately, there is one last lint issue to be solved. I think you just need to add a blank newline to the end of your handler module.

@RiyanaD
Copy link
Contributor Author

RiyanaD commented Oct 23, 2024 •
edited
Loading

Hey @RiyanaD, Unfortunately, there is one last lint issue to be solved. I think you just need to add a blank newline to the end of your handler module.

I have added the newline.

@ZoranPandovski ZoranPandovski merged commit ceb6199 into mindsdb:main Oct 28, 2024
6 of 7 checks passed
@mindsdb mindsdb locked and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MinuraPunchihewa MinuraPunchihewa MinuraPunchihewa approved these changes

@ZoranPandovski ZoranPandovski ZoranPandovski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Integration]: Financial Modeling Prep API Integration
4 participants
@RiyanaD @mindsdbadmin @ZoranPandovski @MinuraPunchihewa