Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [2.5]Remove valid expressions from invalid expressions #38999

Merged
merged 2 commits into from
Jan 6, 2025
Merged

fix: [2.5]Remove valid expressions from invalid expressions #38999

merged 2 commits into from
Jan 6, 2025

Conversation

xiaocai2333
Copy link
Contributor

@xiaocai2333 xiaocai2333 commented Jan 6, 2025 •
edited
Loading

issue: #39014

master pr: #38957
master pr: #39012

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 6, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 6, 2025
@czs007
Copy link
Collaborator

czs007 commented Jan 6, 2025

/approve
/lgtm

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 6, 2025

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 6, 2025

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Jan 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.05%. Comparing base (b9da6a5) to head (1bea5fd).
Report is 2 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.5   #38999        /-   ##
===========================================
  Coverage   69.45%   81.05%    11.60%     
===========================================
  Files         294     1383      1089     
  Lines       26419   195518    169099     
===========================================
  Hits        18349   158486    140137     
- Misses       8070    31462     23392     
- Partials        0     5570      5570
Components Coverage Δ
Client 78.26% <ø> (∅)
Core 69.45% <ø> (ø)
Go 83.04% <100.00%> (∅)
Files with missing lines Coverage Δ
internal/datacoord/server.go 73.22% <100.00%> (ø)

... and 1088 files with indirect coverage changes

@xiaocai2333
Copy link
Contributor Author

rerun go-sdk

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 6, 2025

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@xiaocai2333
fix go sdk
1bea5fd 
Signed-off-by: Cai Zhang <[email protected]>
@xiaocai2333 xiaocai2333 changed the title enhance: [2.5]Increase the buffer capacity of notifyIndexChan to support concurrency enhance: [2.5]Remove valid expressions from invalid expressions Jan 6, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 6, 2025

@xiaocai2333 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

rerun cpp-unit-test

@xiaocai2333 xiaocai2333 changed the title enhance: [2.5]Remove valid expressions from invalid expressions fix: [2.5]Remove valid expressions from invalid expressions Jan 6, 2025
@mergify mergify bot added kind/bug Issues or changes related a bug ci-passed labels Jan 6, 2025
congqixia
congqixia approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit e6dd3e5 into milvus-io:2.5 Jan 6, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@cydrain cydrain Awaiting requested review from cydrain

Assignees

@czs007 czs007

@congqixia congqixia

Labels
approved area/test ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xiaocai2333 @czs007 @sre-ci-robot @congqixia