Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: handle geometry names in get_speed_positionfixes #419

Merged
merged 1 commit into from
May 31, 2022

Conversation

bifbof
Copy link
Collaborator

@bifbof bifbof commented May 25, 2022

Same bug as in #418. "geom" was used instead of .geometry.
Additionally replaced the .apply methods with vectorized ones and added a test for planar crs.

@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #419 (7ccdd1c) into master (c401f3d) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #419       /-   ##
==========================================
  Coverage   97.57%   97.68%    0.10%     
==========================================
  Files          39       39              
  Lines        1858     1859        1     
  Branches      273      270       -3     
==========================================
  Hits         1813     1816        3     
  Misses         18       17       -1     
  Partials       27       26       -1     
Impacted Files Coverage Δ
trackintel/model/util.py 100.00% <100.00%> ( 4.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c401f3d...7ccdd1c. Read the comment docs.

Copy link
Member

@henrymartin1 henrymartin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! It is a shame that we never implemented benchmarks. Would be nice to see how much faster this method is ;-)

@henrymartin1 henrymartin1 merged commit d3e0f98 into mie-lab:master May 31, 2022
@bifbof bifbof deleted the fix_speed_pfs branch May 31, 2022 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants