Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Set index for mask in location_identifier #408

Merged
merged 1 commit into from
May 23, 2022
Merged

BUG: Set index for mask in location_identifier #408

merged 1 commit into from
May 23, 2022

Conversation

bifbof
Copy link
Collaborator

@bifbof bifbof commented May 20, 2022

closes #403

@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #408 (9bd20bb) into master (5dee60a) will increase coverage by 0.28%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #408      +/-   ##
==========================================
+ Coverage   96.71%   96.99%   +0.28%     
==========================================
  Files          39       39              
  Lines        1888     1865      -23     
  Branches      283      275       -8     
==========================================
- Hits         1826     1809      -17     
+ Misses         27       24       -3     
+ Partials       35       32       -3
Impacted Files Coverage Δ
trackintel/analysis/location_identification.py 99.06% <100.00%> (ø)
trackintel/geogr/distances.py 94.56% <0.00%> (+1.36%) ⬆️
trackintel/preprocessing/util.py 100.00% <0.00%> (+12.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dee60a...9bd20bb. Read the comment docs.

henrymartin1
henrymartin1 approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@henrymartin1 henrymartin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@henrymartin1 henrymartin1 merged commit b87ab37 into mie-lab:master May 23, 2022
@bifbof bifbof deleted the bug_location_identifier branch May 23, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrymartin1 henrymartin1 henrymartin1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in location_identifier for pre_filter=False and non-serial index
2 participants
@bifbof @henrymartin1