-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node debug Step Over/Into hangs in 1.9 #19841
Comments
Also having this issue. |
Also having issues with the debugger becoming unresponsive and hanging. |
Which version of node are you using? Which version of the node debugger are you using? |
binary versions $ node -v
v5.8.0
$ node-debug -v
Node Inspector v0.12.7 launch.json config {
"version": "0.2.0",
"configurations": [
{
"type": "node",
"request": "launch",
"name": "Launch Program",
"program": "${workspaceRoot}/index.js",
"cwd": "${workspaceRoot}"
},
{
"type": "node",
"request": "attach",
"name": "Attach to Process",
"port": 5858
}
]
} |
@wshirey what OS is this? |
oops, sorry, I mistyped... It should have read: |
@wshirey makes sense, since you said above that you are using node v5.8. |
I'm using node v6.9.5 with OSX 10.12.3 I've tried both |
We are not able to reproduce this problem. Do you you have a minimal repro that we can try? Can you try to run VS Code without extensions? From the command line, execute: |
For me, this issue appears to be related to the number & size of the local variables. In particular, creating large objects (not arrays) causes the debugger to hang a lot when breakpoints are hit - and for some reason it does seem to be worse in 1.9. I have since changed my configuration to |
That's similar to what I'm finding too. For simple node scripts, it usually doesn't hang (although occasionally it does). But with a more complex express app with |
Please post a screenshot of the debugger UI when it hangs. |
I think this might be the same issue as #20608 |
FYI @weinand @roblourens The issue has already been logged and "fixed": microsoft/vscode-chrome-debug-core#148 I say "fixed" because the issue is a timing problem - what's happening is that the exact order of the step, resume, evaluate and pause events change depending upon how much work is going on in the process. I expected much better from Microsoft. Can you please fix this. And not by increasing the delay - make the adaptor robust enough to handle events in any order. |
It's really a V8 bug, I was able to repro this in Chrome devtools too - I expected better from Google :P @isidorn Did anything change in 1.9 about when the evaluate request for a watch is sent after a step? |
@roblourens no, as far as I am aware. |
Ok, I'll look at this again and see if there's a better fix. |
I went back to investigate this and it seems to have been fixed by #21524, with or without my timing hack. Now we don't globally eval watches, and while stepping, the eval request is only sent once the debug adapter has successfully paused. Would appreciate it if you try it out in the Insiders build and let me know. |
Could someone on this thread who saw this problem confirm it is fixed with the latest insiders builds? I tried to verify it, but I cannot reproduce in 1.10.2, so I cannot tell for sure if it is fixed. |
I'm on 1.10.2 and it looks fixed to me, 👍 |
I was getting thit A LOT, seems fixed. |
Steps to Reproduce:
This did not happen in 1.8.1 but started happening right after 1.9.
The text was updated successfully, but these errors were encountered: