Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client should retry the request when receiving 409 #104834

Closed
lszomoru opened this issue Aug 17, 2020 · 7 comments
Closed

Client should retry the request when receiving 409 #104834

lszomoru opened this issue Aug 17, 2020 · 7 comments
Assignees
@sandy081
Labels
settings-sync verified Verification succeeded
Milestone
July 2020 Recovery 2

Comments

@lszomoru
Copy link
Member

Client should retry the request when receiving a 409 and 412 from the server.
@sandy081 sandy081 changed the title Settings sync - improve client retry logic Client should retry the request when receiving 409 Aug 17, 2020
@sandy081
Copy link
Member

@Tyriar FYI

@miguelsolorio
Copy link
Contributor

We should also update the error message. From a user's perspectives, these mean nothing and don't provide any guidance.

image

image

@sandy081
Copy link
Member

@misolori These message are not supposed to be surfaced to user. Currently 412 error is handled and retried without bailing out. Can you please provide the settings sync log when you saw 412 ?

@miguelsolorio
Copy link
Contributor

@sandy081 sorry I wasn't able to retrieve those logs, I'll see if it appears again.

@sandy081 sandy081 added the candidate Issue identified as probable candidate for fixing in the next release label Aug 19, 2020
@sandy081 sandy081 added this to the July 2020 Recovery milestone Aug 19, 2020
@sandy081
Copy link
Member

Reopening for candidate discussion

@sandy081 sandy081 reopened this Aug 19, 2020
@sandy081
Copy link
Member

@misolori I would recommend to file a separate issue for 412 scenario you are seeing.

@sandy081 sandy081 removed the candidate Issue identified as probable candidate for fixing in the next release label Aug 19, 2020
@Tyriar Tyriar mentioned this issue Aug 24, 2020
Closed
sandy081 added a commit that referenced this issue Aug 25, 2020
@sandy081
Fix #104834
e6e146b
@sandy081 sandy081 mentioned this issue Aug 25, 2020
Merged
sandy081 added a commit that referenced this issue Aug 25, 2020
@sandy081
Merge pull request #105341 from microsoft/sandy081/fix104834
a047975 
Fix #104834
@isidorn
Copy link
Contributor

isidorn commented Aug 25, 2020

Fix looks good, adding verified label.

@isidorn isidorn added the verified Verification succeeded label Aug 25, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
settings-sync verified Verification succeeded
Projects
None yet
Milestone
July 2020 Recovery 2
Development

No branches or pull requests
5 participants
@isidorn @lszomoru @sandy081 @miguelsolorio and others