-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[openal-soft] Update to 1.24.0 #42196
Conversation
The downstream
The downstream
More logs you could get from https://dev.azure.com/vcpkg/public/_build/results?buildId=109407&view=artifacts&pathAsName=false&type=publishedArtifacts |
Thanks Cheney! The windows-static ones seem to be due to openal-soft's WASAPI backend now requiring linking against avrt, and that dependency doesn't get communicated properly in static builds. Patching libmikmod would probably fix it, but that doesn't seem like the ideal approach. I'm not sure what's causing the issues on macOS, since sfml also has code that uses |
Add the missing link libs to the installed pc files ( |
That's why I usually add the command line when reporting errors. Look:
The line lacks the desired C standard option. And so you don't even get C 11. And so you don't get |
94b867b
to
a8d4d9b
Compare
The The openal.pc pkg-config file seems to be correct and includes However, I'm not convinced that the CMake build for libmikmod is actually reading those CMake target files in the It feels to me like CMake's built-in |
libmikmod does use CMake's built-in
This module is a bad example. It only uses So IMO there are two task:
|
e9ab33a
to
7dd6af7
Compare
7dd6af7
to
8dae3e4
Compare
Usage test passed with x64-windows-static triplet. |
Thanks for the update! |
./vcpkg x-add-version --all
and committing the result.