fix #178 InstanceOfType on null value #179
Conversation
|
@LarsCelie, It will cover your contributions to all Microsoft-managed open source projects. |
|
@LarsCelie, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
| public void InstanceOfTypeShouldFailWhenValueIsNull() | ||
| { | ||
| Action action = () => TestFrameworkV2.Assert.IsInstanceOfType(null, typeof(AssertTests)); | ||
| TestFrameworkV2.Assert.ThrowsException<TestFrameworkV2.AssertFailedException>(action); |
There was a problem hiding this comment.
Can we use ActionUtility.ActionShouldThrowExceptionOfType instead please. Any issue with ThrowsException would leave these tests in an indeterminate state too. Hence the ask.
| } | ||
|
|
||
| [TestMethod] | ||
| public void InstanceOfTypeShouldFailWhenTypeIsNull() |
There was a problem hiding this comment.
If possible can we add a positive test too please?
Not sure if the tests provided are desired, so i can remove them if necessary.