Fix write conflicts in parallel output #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haplois
previously approved these changes
Apr 14, 2022
|
I've used the project from #1063 (comment) that @JustArchi so helpfully provided, and run it 100 times in a loop without error. And without any regression in execution time. This might be slightly improved by locking only when we grab or initialize the State, and then making the edits on concurrent dictionary, but it adds more logic and I guess the improvements would be marginal. |
Evangelink
previously approved these changes
Apr 14, 2022
src/Adapter/PlatformServices.Shared/netstandard1.3/Services/ns13ThreadSafeStringWriter.cs
Outdated
Show resolved
Hide resolved
…13ThreadSafeStringWriter.cs Co-authored-by: Amaury Levé <[email protected]>
Evangelink
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace instance lock with static lock, because there can be multiple different ThreadSafeStringWriters writing into the same async context. Reduce the locking only to state initialization and dictionary lookups and edits, but don't hold the lock over StringBuilder operations.
Add a wrapper for StringBuilder that locks on every method on the instance level, so when two threads get the same instance of StringBuilder then will sync together, but they won't sync with other threads that have different string builder.
Fix #1063