Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top of text is cut off when the terminal is in full screen mode #17596

Open
dimbleby opened this issue Jul 22, 2024 · 6 comments
Open

Top of text is cut off when the terminal is in full screen mode #17596

dimbleby opened this issue Jul 22, 2024 · 6 comments
Assignees
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.

Comments

@dimbleby
Copy link
Member

Windows Terminal version

1.20.11781.0

Windows build number

10.0.22631.3880

Other Software

No response

Steps to reproduce

maximize window, read text

Expected Behavior

whole of text visible

Actual Behavior

top of text not visible

image

@dimbleby dimbleby added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jul 22, 2024
Copy link

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Closed similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

@dimbleby
Copy link
Member Author

#1055 is similar, but ancient (and fixed)

As in that one, I see this behaviour only on my non-primary monitors (1920 x 1080) and not on my primary monitor (3000 x 2000)

@carlos-zamora carlos-zamora added Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Product-Terminal The new Windows Terminal. labels Jul 24, 2024
@carlos-zamora
Copy link
Member

Thanks for filing. Can you share your settings.json? Also, what's your display scale /?

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jul 24, 2024
@carlos-zamora carlos-zamora added this to the Backlog milestone Jul 24, 2024
@dimbleby
Copy link
Member Author

settings https://gist.github.com/dimbleby/6705f249d8fd54c21f2ad6f354e7aad3

scale "100% (Recommended)"

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Jul 25, 2024
@carlos-zamora carlos-zamora added Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. Priority-3 A description (P3) and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Attention The core contributors need to come back around and look at this ASAP. labels Jul 31, 2024
@carlos-zamora
Copy link
Member

Thanks! We can't repro this, but we'll keep it open for investigation. 😊

@lhecker lhecker changed the title Top of text is cut off when maximizing terminal on non-primary monitor Top of text is cut off when the terminal is in full screen mode Aug 19, 2024
@lhecker
Copy link
Member

lhecker commented Aug 19, 2024

I've received a memory dump from @dimbleby and it shows that all vertical glyph coordinates are correct. But the dump also shows that the swap chain target size is reported as 1920x1081 which is 1px too much vertically. This likely causes the swap chain panel inside the UI tree to be misaligned and shoved up. I believe the entire window is 1px too tall after maximizing and probably indicative of a bug in IslandWindow or similar.

The way to reproduce the issue is by using this font at a 10pt size: input-mono.zip. (This is Input Mono with a customized 0.9x line height.) Then press Alt-Enter or F11 to full-screen the window.

For instance, at 100% display scale these are the first two rows of text at the top-left of the screen:
image

As you can see, the first row of pixels is missing. The issue also reproduces at 150% display scale on my 4K display and is even more pronounced there.

@lhecker lhecker modified the milestones: Backlog, Terminal v1.23 Aug 19, 2024
@lhecker lhecker self-assigned this Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

3 participants