Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find dialog continually returns focus to found element after clicking out of the dialog #17549

Closed
dovholuknf opened this issue Jul 11, 2024 · 2 comments
Closed

Find dialog continually returns focus to found element after clicking out of the dialog #17549

dovholuknf opened this issue Jul 11, 2024 · 2 comments
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. Severity-Blocking We won't ship a release like this! No-siree.

Comments

@dovholuknf
Copy link

Description of the new feature/enhancement

Find dialog returns focus even when not 'active', leading to poor UX/ergonomic

Proposed technical implementation details (optional)

  • Start a terminal and dump a load of text to the terminal.
  • ctrl shift f (or whatever) to find some unique piece of data in the terminal scrollback and rejoice when the terminal shows you the line (it would be swell if the find window didn't obscure your text though). example:
    image
  • click in the terminal pane to enter a command (do not close the find dialog), expecting for the scrollback to be returned to the bottom
  • start typing your command and notice that the scrollback is returned to the position of the current 'find' (which imo is unexpected)
  • out of frustration, hit the esc key, expecting the find dialog to close (be frustrated when it doesn't)
  • press ctrl shift f again to enter find dialog, then press esc and start typing and be happy to see the scrollback/focus returned to the bottom

I tried to find a matching issue but didn't find one.

demonstration below

terminal
@dovholuknf dovholuknf added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jul 11, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 11, 2024
@carlos-zamora carlos-zamora added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jul 17, 2024
@carlos-zamora carlos-zamora added this to the Terminal v1.22 milestone Jul 17, 2024
@zadjii-msft zadjii-msft added the Severity-Blocking We won't ship a release like this! No-siree. label Aug 20, 2024
@DHowett
Copy link
Member

DHowett commented Aug 22, 2024

Thanks for the report! I'm looking at our all-up backlog and I think it's a /dup of #17301.

@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@microsoft-github-policy-service microsoft-github-policy-service bot removed this from the Terminal v1.22 milestone Aug 22, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@DHowett @carlos-zamora @zadjii-msft @dovholuknf