Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce TerminalTab and TabBase to just Tab #17529

Open
DHowett opened this issue Jul 8, 2024 · 1 comment
Open

Reduce TerminalTab and TabBase to just Tab #17529

DHowett opened this issue Jul 8, 2024 · 1 comment
Assignees
@zadjii-msft
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Milestone
Terminal v1.23

Comments

@DHowett
Copy link
Member

DHowett commented Jul 8, 2024

This is a code hygiene item that we missed from the non-Terminal Pane work.
@DHowett DHowett added Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. labels Jul 8, 2024
@DHowett DHowett added this to the Terminal v1.22 milestone Jul 8, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 8, 2024
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 17, 2024
@zadjii-msft
Copy link
Member

I started this in: dev/migrie/f/sui-panes...dev/migrie/b/remove-terminaltab

though, I think i deleted the SUI pane branch so that delta doesn't work anymore.

dev/migrie/f/992-redux-redux...dev/migrie/b/remove-terminaltab may be a closer diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.23
Development

No branches or pull requests
3 participants
@DHowett @carlos-zamora @zadjii-msft