Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rush] rush deploy does not copy files named with asterisk(*) #4864

Open
niyan-ly opened this issue Aug 6, 2024 · 2 comments
Open

[rush] rush deploy does not copy files named with asterisk(*) #4864

niyan-ly opened this issue Aug 6, 2024 · 2 comments

Comments

@niyan-ly
Copy link

niyan-ly commented Aug 6, 2024

Summary

rush deploy does not copy files that named including asterisk(*), like :fileName(.*).ts

Repro steps

  1. in any rush managed project, exec rush init-deploy -t project to create a deploy conf
  2. add a file in project which path like service/src/:(cate|name)/:fileNmae(.*).ts.ts
  3. exec rush deploy -t project and check for the deployment folder

Expected result:
should include all files
Actual result:
file named with '*' is not copied.

Details

Standard questions

Please answer these questions to help us investigate your issue more quickly:

Question Answer
@microsoft/rush globally installed version? 5.131.0
rushVersion from rush.json? 5.131.0
useWorkspaces from rush.json? don't have this options set
Operating system? both Mac / Linux have been tested, same issue
Would you consider contributing a PR?
Node.js version (node -v)? both v20, v22 have same issue
@niyan-ly niyan-ly changed the title [rush] rush deploy does not copy file named with asterisk(*) [rush] rush deploy does not copy files named with asterisk(*) Aug 6, 2024
@iclanton
Copy link
Member

iclanton commented Aug 7, 2024

Are you saying that Glob patterns aren't working, or that you have files with asterisk characters in their filenames? So you have files on disk with the literal filename service/src/:(cate|name)/:fileNmae(.*).ts.ts?

rush deploy uses minimatch and npm-packlist to decide what to include. This is an extremely obscure case, so our team likely won't have time to investigate and introduce a fix, but if you come up with one, we'll probably accept it.

@niyan-ly
Copy link
Author

niyan-ly commented Aug 10, 2024 •
edited
Loading

So you have files on disk with the literal filename service/src/:(cate|name)/:fileNmae(.*).ts.ts?

Yes! Our project use filed-based router, so running rush deploy currently would miss lots of files. Actually lots of node.js projects like next.js are using file-based router, it is rather popular.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Bug Triage
Status: Low priority
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iclanton @niyan-ly