Avr #409
Merged
Avr #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tballmsft
commented
Oct 3, 2016
tballmsft
commented
- refactoring to support AVR assembler and Thumb Assembler
- refactoring of backthumb.ts to backbase.ts, hexfile.ts, backthumb.ts
# Conflicts: # pxtlib/emitter/avr.ts
# Conflicts: # pxtlib/emitter/assembler.ts # pxtlib/emitter/thumb.ts
mmoskal
reviewed
Oct 4, 2016
| @@ -3240,6 3251,7 @@ cmd("extract [FILENAME] - extract sources from .hex/.jsz file, stdin ( | |||
| cmd("test - run tests on current package", testAsync, 1) | |||
| cmd("gendocs - build current package and its docs", gendocsAsync, 1) | |||
| cmd("format [-i] file.ts... - pretty-print TS files; -i = in-place", formatAsync, 1) | |||
| cmd("testassembler - test the assemblers", testAssemblers) | |||
There was a problem hiding this comment.
Needs to have ,1) or ,2) to hide from simple help
| // more special characters to handle | ||
| if (s.indexOf("@") >= 0) { | ||
| m = /^(\w )@(-?\d )$/.exec(s) | ||
| if (m) { | ||
| if (mul != 1) | ||
| this.directiveError(lf("multiplication not supported with saved stacks")); | ||
| if (this.stackpointers.hasOwnProperty(m[1])) | ||
| // TODO: ARM-specific??? |
| v = 4 * (this.stack - this.stackpointers[m[1]] parseInt(m[2])) | ||
| else | ||
| this.directiveError(lf("saved stack not found")) | ||
| } | ||
|
|
||
| // TODO: ARM-specific??? |
| @@ -390,17 387,14 @@ namespace ts.pxtc.assembler { | |||
| if (this.finalEmit) | |||
| this.directiveError(lf("unknown label: {0}", name)); | |||
| else | |||
| // Is this a joke? | |||
There was a problem hiding this comment.
There needs to be a value here, and in the first emit labels might not be resolved yet. I think there was some reason not to use 0
| // - pop/push receive register sets: { r0, r3, r4 } | ||
| // - r0 is the current value (from expression evaluation) | ||
| // - also used (fixed) are r1, r2, r5, r6 (what about r3, r4?) | ||
| // - registers for runtime calls (r1,r2,r3) |
| // - registers are 32-bit (really???) | ||
| // - pop/push receive register sets: { r0, r3, r4 } | ||
| // - r0 is the current value (from expression evaluation) | ||
| // - also used (fixed) are r1, r2, r5, r6 (what about r3, r4?) |
There was a problem hiding this comment.
r5 is for captured locals in lambda and r6 for globals; it's unclear why not r4 and r5
| return r | ||
| } | ||
|
|
||
| // TODO: generalize and lift out ARM-specific code |
There was a problem hiding this comment.
I think there's nothing ARM-specific in this function
pelikhan
reviewed
Oct 5, 2016
| @@ -0,0 1,77 @@ | |||
| { | |||
There was a problem hiding this comment.
we already have a "tests" folder, can you move all the /test/avr/ files under there?
pelikhan
reviewed
Oct 5, 2016
| @@ -0,0 1,183 @@ | |||
| import re | |||
There was a problem hiding this comment.
pxt is fundamentally a JS project. We should avoid adding dependencies to Python. Can this be rewritten in JS instead?
| @@ -0,0 1,77 @@ | |||
| { | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.