test: unflake contextmenu recorder test #31749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
force-pushed
the
recorder-contextmenu
branch
from
d5de310
to
1e1ec4c
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dgozman
reviewed
Jul 18, 2024
packages/playwright-core/src/server/injected/recorder/recorder.ts
Outdated
Show resolved
Hide resolved
| 'button: pointermove', | ||
| 'button: mousemove', | ||
| // trusted right click | ||
| 'button: pointerup', |
There was a problem hiding this comment.
Do you understand why is there a pointerup at the start of the right-click?
There was a problem hiding this comment.
pointer events were a fun way to try to describe how the world works for non mouse based inputs... https://w3c.github.io/pointerevents/#the-pointerup-event
Making all the events compatible/with pages is such a fun mess :) (signed, ex-(mobile)-browser/standards-dev)
This comment has been minimized.
This comment has been minimized.
mxschmitt
force-pushed
the
recorder-contextmenu
branch
from
1e1ec4c
to
607729b
Compare
dgozman
approved these changes
Jul 26, 2024
Test results for "tests 1"2 failed 6 flaky29198 passed, 694 skipped Merge workflow run. |
Test results for "tests others"1 flaky17754 passed, 478 skipped Merge workflow run. |
Test results for "tests 2"2 fatal errors, not part of any test 91 flaky212786 passed, 9354 skipped, 1412 did not run Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at the last 5 runs on the flakiness dashboard, it shows that Chromium based browsers on Windows are red on this test. This is because on windows 'auxclick' fires before 'contextmenu' (this was also reproduced on a minimal example) which causes an action to be in progress, so when the actual 'contextmenu' fires, it does not emit any actions.
In order to fix it, we ignore right click 'auxclick' events, which sound reasonable, since they are handled via 'contextmenu' event.