-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: unflake contextmenu recorder test #31749
Conversation
d5de310
to
1e1ec4c
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
packages/playwright-core/src/server/injected/recorder/recorder.ts
Outdated
Show resolved
Hide resolved
'button: pointermove', | ||
'button: mousemove', | ||
// trusted right click | ||
'button: pointerup', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you understand why is there a pointerup
at the start of the right-click?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pointer events were a fun way to try to describe how the world works for non mouse based inputs... https://w3c.github.io/pointerevents/#the-pointerup-event
Making all the events compatible/with pages is such a fun mess :) (signed, ex-(mobile)-browser/standards-dev)
This comment has been minimized.
This comment has been minimized.
1e1ec4c
to
607729b
Compare
Test results for "tests 1"2 failed 6 flaky29198 passed, 694 skipped Merge workflow run. |
Test results for "tests others"1 flaky17754 passed, 478 skipped Merge workflow run. |
Test results for "tests 2"2 fatal errors, not part of any test 91 flaky212786 passed, 9354 skipped, 1412 did not run Merge workflow run. |
Looking at the last 5 runs on the flakiness dashboard, it shows that Chromium based browsers on Windows are red on this test. This is because on windows 'auxclick' fires before 'contextmenu' (this was also reproduced on a minimal example) which causes an action to be in progress, so when the actual 'contextmenu' fires, it does not emit any actions.
In order to fix it, we ignore right click 'auxclick' events, which sound reasonable, since they are handled via 'contextmenu' event.