Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose DirectML provider to Python #3359

Closed
wants to merge 4 commits into from
Closed

Expose DirectML provider to Python #3359

wants to merge 4 commits into from

Conversation

RobinKa
Copy link

@RobinKa RobinKa commented Mar 29, 2020

Description: Exposed the DirectML (DML) provider to Python.

Motivation and Context
Previously the DML provider was not exposed to python.

Fixes #3358

@RobinKa RobinKa requested a review from a team as a code owner March 29, 2020 21:38
@msftclas
Copy link

msftclas commented Mar 29, 2020 •
edited

CLA assistant check
All CLA requirements met.

@RobinKa RobinKa mentioned this pull request Mar 29, 2020
Closed
@pranavsharma
Copy link
Contributor

/azp run Windows CPU CI Pipeline, Linux CPU CI Pipeline, Linux CPU x64 NoContribops CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, MacOS CI Pipeline, MacOS NoContribops CI Pipeline, Win CPU x64 NoContribops CI Pipeline, Win CPU x86 CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, Python Packaging Pipelines

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@jywu-msft
Copy link
Member

/azp run Linux CPU CI Pipeline, Linux CPU x64 NoContribops CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Windows CPU CI Pipeline, Windows GPU CI Pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

fdwr
fdwr previously approved these changes May 2, 2020
View reviewed changes
Copy link
Contributor

@fdwr fdwr left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, consistent with the pattern for existing providers - thanks. (I'm on DML though, and so we might want someone from the ORT team itself who is more familiar with Python bindings to also chime in)

@pranavsharma
Copy link
Contributor

@RobinKa can you resolve the conflicts? We're planning to do a release soon and it'll be nice to get this as part of the release. Thanks!

@RobinKa
Copy link
Author

RobinKa commented May 5, 2020 •
edited

When I try to check any of the builds I just get "Build not found" (for example this one).

// Edit: oh sorry you mean merge conflicts, I'll take a look.

@pranavsharma
Copy link
Contributor

When I try to check any of the builds I just get "Build not found" (for example this one).

// Edit: oh sorry you mean merge conflicts, I'll take a look.

Once you resolve the conflicts we can trigger the build.

@RobinKa
Merge remote-tracking branch 'upstream/master'
e9d2ae5 
# Conflicts:
#	onnxruntime/python/onnxruntime_pybind_state.cc
#	setup.py
#	tools/ci_build/build.py
@RobinKa
Copy link
Author

RobinKa commented May 5, 2020 •
edited

Alright I resolved the conflicts. There are still some tests in onnx_backend_test_series.py failing for me (but they also fail on the upstream master).

@pranavsharma
Copy link
Contributor

/azp run Linux CPU CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,MacOS CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,MacOS NoContribops CI Pipeline,Linux CPU x64 NoContribops CI Pipeline,Windows CPU CI Pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 9 pipeline(s).

@goloskokovic goloskokovic mentioned this pull request Jun 13, 2020
Closed
@faxu
Copy link
Contributor

faxu commented Jun 25, 2020

@RobinKa can you address conflicts?

cameronmaske added a commit to cameronmaske/onnxruntime that referenced this pull request Jul 27, 2020
@cameronmaske
Ported @RobinKa's changes to expose DirectML to python (microsoft#3359)…
9db3d7a 
… against latest master
@cameronmaske cameronmaske mentioned this pull request Jul 27, 2020
Merged
@cameronmaske
Copy link
Contributor

cameronmaske commented Jul 30, 2020 •
edited

@faxu I have attempted to resolve these conflicts on a separate PR #4630

@hariharans29
Copy link
Member

Closing as this is a dupe of #4630

hariharans29 pushed a commit that referenced this pull request Sep 8, 2020
@cameronmaske
Expose DirectML provider to python (conflicts resolved from #3359) (#…
4553b2e 
…4630)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdwr fdwr fdwr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to use DirectML execution provider from Python?
8 participants
@RobinKa @msftclas @pranavsharma @jywu-msft @faxu @cameronmaske @hariharans29 @fdwr