-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose DirectML provider to Python #3359
Conversation
/azp run Windows CPU CI Pipeline, Linux CPU CI Pipeline, Linux CPU x64 NoContribops CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, MacOS CI Pipeline, MacOS NoContribops CI Pipeline, Win CPU x64 NoContribops CI Pipeline, Win CPU x86 CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, Python Packaging Pipelines |
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
/azp run Linux CPU CI Pipeline, Linux CPU x64 NoContribops CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Windows CPU CI Pipeline, Windows GPU CI Pipeline |
Azure Pipelines successfully started running 6 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, consistent with the pattern for existing providers - thanks. (I'm on DML though, and so we might want someone from the ORT team itself who is more familiar with Python bindings to also chime in)
@RobinKa can you resolve the conflicts? We're planning to do a release soon and it'll be nice to get this as part of the release. Thanks! |
When I try to check any of the builds I just get "Build not found" (for example this one). // Edit: oh sorry you mean merge conflicts, I'll take a look. |
Once you resolve the conflicts we can trigger the build. |
# Conflicts: # onnxruntime/python/onnxruntime_pybind_state.cc # setup.py # tools/ci_build/build.py
Alright I resolved the conflicts. There are still some tests in |
/azp run Linux CPU CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,MacOS CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,MacOS NoContribops CI Pipeline,Linux CPU x64 NoContribops CI Pipeline,Windows CPU CI Pipeline |
Azure Pipelines successfully started running 9 pipeline(s). |
@RobinKa can you address conflicts? |
… against latest master
Closing as this is a dupe of #4630 |
Description: Exposed the DirectML (DML) provider to Python.
Motivation and Context
Previously the DML provider was not exposed to python.
Fixes #3358