Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix printing the last day in a 400 year cycle. #1767

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BillyONeal
Copy link
Member

This was reported to me by "Jag S" over email trying to print 2000-12-31. The cause appears very similar to https://github.com/microsoft/cpprestsdk/pull/1550/files/198b034679cf7f962e242977b99ea5c63ad9eb03

I think this will cause a denial of service bug similar to the last day 365 one in the year 2400.

This was reported to me by "Jag S" over email trying to print 2000-12-31. The cause appears very similar to https://github.com/microsoft/cpprestsdk/pull/1550/files/198b034679cf7f962e242977b99ea5c63ad9eb03

I think this will cause a denial of service bug similar to the last day 365 one in the year 2400.
@baptistemcn
Copy link

Member of the team of "Jag S" here, Thank you very much !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants