Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new version of server task ManualValidation #19899

Conversation

v-gayatrij
Copy link
Contributor

@v-gayatrij v-gayatrij commented May 22, 2024

Task name: ManualValidationV1

Description: Adding new version for server task Manual Validation. This new version has an added property "approvers" that can be used to restrict pipeline approval to specified users.
Associated WI: 2082321

Documentation changes required: Y

Added unit tests: (Y/N)

Attached related issue: Y

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@v-gayatrij v-gayatrij requested review from a team and manolerazvan May 23, 2024 04:10
Tasks/ManualValidationV1/task.json Outdated Show resolved Hide resolved
Tasks/ManualValidationV1/task.json Outdated Show resolved Hide resolved
@v-gayatrij v-gayatrij merged commit 032707c into microsoft:master May 23, 2024
11 checks passed
@@ -0,0 +1,69 @@
{
"id": "2003AD3A-104A-451A-9238-60474AB294E6",
"name": "ManualValidation",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Do you have an estimate for when this will be released/available?

@neeles83
Copy link

Will this also limit the person that starts the pipeline from approving it himself even if he has approvers rights?
It wouldn"t make sense to have a ManualValidation build-in if the requestor can approve it himself or have a second value stating that only an approver can approve if it"s not the one initiating the pipeline.

If it"s an automated pipeline triggered by a merger, than there already was a 4th eye approving the merger regardless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants