Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New task InstallKubelogin #18384

Merged

Conversation

YevheniiKholodkov
Copy link
Contributor

@YevheniiKholodkov YevheniiKholodkov commented May 26, 2023

Task name: KubeloginInstallerV0 (renamed from InstallKubelogin)

Description: Kubernetes is managed with kubectl. This can also (like az aks) use AAD AuthN/AuthZ for Kubernetes access. When AKS is configured to use AAD RBAC, kubectl will use an out of process flow (browser, device code) to authenticate the user. Kubelogin is a kubectl plugin that allows for more authentication flows, including the following once supported by Service Connection schemes:
Service Principal secret
Service Principal certificate
Managed Identity
Workload identity federation

Documentation changes required: (Y/N) Y

Added unit tests: (Y/N) Y

Attached related issue: (Y/N) N

Checklist:

  • [*] Task version was bumped - please check instruction how to do it
  • [*] Checked that applied changes work as expected

@YevheniiKholodkov YevheniiKholodkov changed the title Users/ykholodkov/kubelogin New task InstallKubelogin May 26, 2023
@mmrazik
Copy link
Collaborator

mmrazik commented May 26, 2023

Please, add this task also to .github/CODEOWNERS

Copy link
Contributor

@LeftTwixWand LeftTwixWand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new task looks great👍
Just added some comments about the code and the docks.

@ghost
Copy link

ghost commented Jun 9, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@ghost ghost self-requested a review as a code owner June 20, 2023 13:19
@YevheniiKholodkov YevheniiKholodkov merged commit 476f74e into microsoft:master Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants