-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New task InstallKubelogin #18384
Merged
YevheniiKholodkov
merged 33 commits into
microsoft:master
from
YevheniiKholodkov:users/ykholodkov/kubelogin
Jun 22, 2023
Merged
New task InstallKubelogin #18384
YevheniiKholodkov
merged 33 commits into
microsoft:master
from
YevheniiKholodkov:users/ykholodkov/kubelogin
Jun 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YevheniiKholodkov
changed the title
Users/ykholodkov/kubelogin
New task InstallKubelogin
May 26, 2023
Please, add this task also to .github/CODEOWNERS |
mmrazik
reviewed
May 26, 2023
starkmsu
reviewed
May 26, 2023
Tasks/KubeloginInstallerV0/Tests/DownloadKubeloginReleaseL0Tests.ts
Outdated
Show resolved
Hide resolved
starkmsu
reviewed
May 26, 2023
starkmsu
approved these changes
Jun 8, 2023
LeftTwixWand
reviewed
Jun 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new task looks great👍
Just added some comments about the code and the docks.
Tasks/KubeloginInstallerV0/Strings/resources.resjson/en-US/resources.resjson
Outdated
Show resolved
Hide resolved
Tasks/KubeloginInstallerV0/Strings/resources.resjson/en-US/resources.resjson
Show resolved
Hide resolved
Tasks/KubeloginInstallerV0/Strings/resources.resjson/en-US/resources.resjson
Outdated
Show resolved
Hide resolved
Tasks/KubeloginInstallerV0/Tests/DownloadKubeloginReleaseL0Tests.ts
Outdated
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
Co-authored-by: Vladyslav Horbachov <[email protected]>
…cks, smalls String fixes
…niiKholodkov/azure-pipelines-tasks into users/ykholodkov/kubelogin
ghost
self-requested a review
as a code owner
June 20, 2023 13:19
…-tasks into users/ykholodkov/kubelogin
LeftTwixWand
approved these changes
Jun 21, 2023
…niiKholodkov/azure-pipelines-tasks into users/ykholodkov/kubelogin
ghost
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: KubeloginInstallerV0 (renamed from InstallKubelogin)
Description: Kubernetes is managed with kubectl. This can also (like az aks) use AAD AuthN/AuthZ for Kubernetes access. When AKS is configured to use AAD RBAC, kubectl will use an out of process flow (browser, device code) to authenticate the user. Kubelogin is a kubectl plugin that allows for more authentication flows, including the following once supported by Service Connection schemes:
Service Principal secret
Service Principal certificate
Managed Identity
Workload identity federation
Documentation changes required: (Y/N) Y
Added unit tests: (Y/N) Y
Attached related issue: (Y/N) N
Checklist: